> On Nov 9, 2015, at 17:27, Bryan Drewery <bdrewery_at_FreeBSD.org> wrote: > >> On 11/9/2015 5:17 PM, Garrett Cooper wrote: >> >>> On Nov 9, 2015, at 16:13, Bryan Drewery <bdrewery_at_FreeBSD.org> wrote: >> >> >> ... >> >>> If this is a shell file then it is best to invoke it with 'sh' rather >>> than a chmod/#!. The src checkout should be noexec-safe. >> >> Right. I think it'd be a good idea for me to hunt down other issues though in the build by setting -o noexec. >> >> >> The only thing that concerns me with doing that is that it could result in weirdness, e.g. The osreldate.h generation script in include/ . > > It prepends 'sh'. > > include/Makefile:MK_OSRELDATE_SH= ${.CURDIR}/mk-osreldate.sh > include/Makefile: sh ${MK_OSRELDATE_SH} Yeah... I forgot. I wrote up that patch at iX, and it was iterated over a bit. I was just remembering what happens when you use ${SHELL} (hint: no bueno if your build is kicked off with a csh/non-POSIX sh..). I'll do that soon-ish. Thanks! -NGieReceived on Tue Nov 10 2015 - 01:01:52 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:00 UTC