Re: buildworld broken

From: Bryan Drewery <bdrewery_at_FreeBSD.org>
Date: Fri, 13 Nov 2015 17:48:04 -0800
On 11/9/2015 10:31 PM, Konstantin Belousov wrote:
>> In 19 years of using freebsd, I have never once needed to chflags on an
>> obj directory.  Nothing in the build process sets any non-standard
>> flags in the obj dirs, and a simple rm -rf will remove everything just
>> fine (you would need to sudo the rm -rf if you built as root).
> You do not build amd64 as root, do you ?
> 
> pooma% ls -lo obj-amd64/usr/home/kostik/work/build/bsd/DEV/src/lib32/usr/lib32/libc.so.7
> -r--r--r--  1 root  wheel  schg 1429600 Oct 24 23:23 obj-amd64/usr/home/kostik/work/build/bsd/DEV/src/lib32/usr/lib32/libc.so.7
> 
> This is an annoyance with COMPAT32 build which existed forewer.

r290812 should fix this.

I was not able to reproduce though.

Do you have INSTALL defined in your /etc/make.conf?

Before the fix I had during buildworld:

sh /root/svn/base/tools/install.sh  -o root -g wheel -m 444   -fschg -S
 libthr.so.3 /usr/obj/root/svn/base/lib32/usr/lib32/

It does pass the -fschg flag to install, but it is also using the
install.sh script which just eats the -f flag. The result is:

-rwxr-xr-x  1 root  wheel  uarch 122069 Nov 13 16:36
/usr/obj/root/svn/base/lib32/usr/lib32/libthr.so.3*

I find no schg on libc.so.7 either:

> ~/svn/base # find /usr/obj/root/svn/base -name libc.so.7 -exec ls -alo {} +
> -rw-r--r--  1 root  wheel  uarch 1872397 Nov 13 16:13 /usr/obj/root/svn/base/lib/libc/libc.so.7
> -rwxr-xr-x  1 root  wheel  uarch 1604846 Nov 13 16:35 /usr/obj/root/svn/base/lib32/usr/lib32/libc.so.7
> -rwxr-xr-x  1 root  wheel  uarch 1872397 Nov 13 16:13 /usr/obj/root/svn/base/tmp/lib/libc.so.7
> -rw-r--r--  1 root  wheel  uarch 1604846 Nov 13 16:35 /usr/obj/root/svn/base/world32/root/svn/base/lib/libc/libc.so.7

With the fix the -fschg is removed for the objtree install:

sh /root/svn/base/tools/install.sh  -o root -g wheel -m 444   -S
libc.so.7 /usr/obj/root/svn/base/lib32/usr/lib32/

All is fine in the DESTDIR still:

~/svn/base # make installworld -j15 DESTDIR=/tmp/blah
...
~/svn/base # ls -alo /tmp/blah/{usr/,}lib*/libc.so.7
-r--r--r--  1 root  wheel  schg 1872397 Nov 13 17:41 /tmp/blah/lib/libc.so.7
-r--r--r--  1 root  wheel  schg 1604846 Nov 13 17:42
/tmp/blah/usr/lib32/libc.so.7


-- 
Regards,
Bryan Drewery


Received on Sat Nov 14 2015 - 00:48:10 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:00 UTC