Re: Need help fixing failing locale tests

> On Nov 14, 2015, at 19:18, Craig Rodrigues <rodrigc_at_FreeBSD.org> wrote:
> 
> On Sat, Nov 14, 2015 at 7:05 PM, Craig Rodrigues <rodrigc_at_freebsd.org>
> wrote:
> 
>> Hi,
>> 
>> After the recent locale commits, some of the tests are failing:
>> 
>> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1675/testReport/
>> 
>> I can reproduce two failures quite easily by doing with a newly built
>> world:
>> 
>> /bin/sh /usr/tests/bin/sh/builtins/case7.0
>> /bin/sh /usr/tests/bin/sh/builtins/locale1.0
>> 
>> Can someone look into this and help fix this?
>> 
>> I don't know much about locales, so don't know what to do.
>> 
> 
> 
> I ran the two tests using bash, and got different error messages:
> 
> /usr/local/bin/bash /usr/tests/bin/sh/builtins/case7.0
> /usr/tests/bin/sh/builtins/case7.0: line 7: warning: setlocale: LC_CTYPE:
> cannot change locale (de_DE.ISO8859-1): Invalid argument
> /usr/tests/bin/sh/builtins/case7.0: line 9: warning: setlocale: LC_COLLATE:
> cannot change locale (de_DE.ISO8859-1): Invalid argument
> wrong at 18
> wrong at 23
> 
> /usr/local/bin/bash /usr/tests/bin/sh/builtins/locale1.0
> /usr/tests/bin/sh/builtins/locale1.0: line 45: warning: setlocale:
> LC_CTYPE: cannot change locale (nl_NL.ISO8859-1): Invalid argument
> Failed: $ok -eq 1 at 56
> /usr/tests/bin/sh/builtins/locale1.0: line 64: warning: setlocale: LC_ALL:
> cannot change locale (nl_NL.ISO8859-1): No such file or directory
> Failed: $ok -eq 1 at 68
> Failed: $ok -eq 1 at 74
> /usr/tests/bin/sh/builtins/locale1.0: regel 82: waarschuwing: setlocale():
> LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file
> or directory
> Failed: $ok -eq 1 at 86
> Failed: $ok -eq 1 at 99
> /usr/tests/bin/sh/builtins/locale1.0: regel 107: waarschuwing: setlocale():
> LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file
> or directory
> Failed: $ok -eq 1 at 111
> /usr/tests/bin/sh/builtins/locale1.0: regel 114: waarschuwing: setlocale():
> LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file
> or directory
> Failed: $ok -eq 1 at 118
> /usr/tests/bin/sh/builtins/locale1.0: regel 122: waarschuwing: setlocale():
> LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file
> or directory
> /usr/tests/bin/sh/builtins/locale1.0: regel 128: waarschuwing: setlocale():
> LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file
> or directory
> Failed: $ok -eq 1 at 132
> 
> 
> On my system, I did:
> ls -l /usr/share/locale/de_DE.ISO8859-1/*
> -r--r--r--  1 root  wheel  4642 Nov  6 12:53
> /usr/share/locale/de_DE.ISO8859-1/LC_COLLATE
> lrwxr-xr-x  1 root  wheel    27 Nov  6 12:53
> /usr/share/locale/de_DE.ISO8859-1/LC_CTYPE -> ../la_LN.ISO8859-1/LC_CTYPE
> -r--r--r--  1 root  wheel    18 Nov  6 12:53
> /usr/share/locale/de_DE.ISO8859-1/LC_MESSAGES
> -r--r--r--  1 root  wheel    35 Nov  6 12:53
> /usr/share/locale/de_DE.ISO8859-1/LC_MONETARY
> -r--r--r--  1 root  wheel     6 Nov  6 12:53
> /usr/share/locale/de_DE.ISO8859-1/LC_NUMERIC
> -r--r--r--  1 root  wheel   367 Nov  6 12:53
> /usr/share/locale/de_DE.ISO8859-1/LC_TIME
> 
> ls -l /usr/share/locale/nl_NL.ISO8859-1/*
> lrwxr-xr-x  1 root  wheel   29 Nov  6 12:53
> /usr/share/locale/nl_NL.ISO8859-1/LC_COLLATE ->
> ../la_LN.ISO8859-1/LC_COLLATE
> lrwxr-xr-x  1 root  wheel   27 Nov  6 12:53
> /usr/share/locale/nl_NL.ISO8859-1/LC_CTYPE -> ../la_LN.ISO8859-1/LC_CTYPE
> -r--r--r--  1 root  wheel   18 Nov  6 12:53
> /usr/share/locale/nl_NL.ISO8859-1/LC_MESSAGES
> -r--r--r--  1 root  wheel   35 Nov  6 12:53
> /usr/share/locale/nl_NL.ISO8859-1/LC_MONETARY
> -r--r--r--  1 root  wheel    6 Nov  6 12:53
> /usr/share/locale/nl_NL.ISO8859-1/LC_NUMERIC
> -r--r--r--  1 root  wheel  376 Nov  6 12:53
> /usr/share/locale/nl_NL.ISO8859-1/LC_TIME
> 
> I saw that la_LN.ISO8859-1 does not exist, so the LC_CTYPE symlink is
> pointing to  nothing.

Why were these locales removed?

  58 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_COLLATE
  59 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_CTYPE
  60 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_TIME
  61 OLD_DIRS+=usr/share/locale/la_LN.ISO8859-1
  62 OLD_FILES+=usr/share/locale/la_LN.ISO8859-13/LC_COLLATE
  63 OLD_FILES+=usr/share/locale/la_LN.ISO8859-13/LC_CTYPE
  64 OLD_DIRS+=usr/share/locale/la_LN.ISO8859-13