Re: FreeBSD_HEAD-tests - Build #1704 - Still Unstable

On Tue, Nov 17, 2015 at 20:34:29 +0100, Baptiste Daroussin wrote:
> On Tue, Nov 17, 2015 at 05:36:45PM +0000, jenkins-admin_at_FreeBSD.org wrote:
> > FreeBSD_HEAD-tests - Build #1704 - Still Unstable:
> > 
> > Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD-tests/1704/
> > Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD-tests/1704/changes
> > Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD-tests/1704/console
> > 
> > Change summaries:
> > 
> > No changes
> > 
> > 
> > The failed test cases:
> > 
> > 1 tests failed.
> > FAILED:  test-report.xml.<init>
> > 
> > Error Message:
> > 
> Can someone fix that? or at least show which test is giving unicode in the
> output?

Just did a quick look into this:

https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1704/testReport/test-report/xml/_init_/

"""
org.dom4j.DocumentException: Error on line 52159 of document file:///builds/FreeBSD_HEAD-tests/test-report.xml : An invalid XML character (Unicode: 0x1) was found in the element content of the document. Nested exception: An invalid XML character (Unicode: 0x1) was found in the element content of the document.
"""

And this is the case output contains invalid XML character:

"""
<testcase classname="lib.libcrypt.crypt_test" name="crypt_salts" time="0.044">
<failure message="Test case was expecting a failure but none were raised"/>
<system-err>Test case metadata
------------------

allowed_architectures is empty
allowed_platforms is empty
description = crypt(3) salt consistency checks
has_cleanup = false
required_configs is empty
required_disk_space = 0
required_files is empty
required_memory = 0
required_programs is empty
required_user is empty
timeout = 300

Original stderr
---------------

*** Expected check failure: Old-style/bad inputs fail on FreeBSD: /builds/FreeBSD_HEAD/contrib/netbsd-tests/lib/libcrypt/t_crypt.c:140: Test 22 ^A^BUZoIyj/Hy/c != ^A^Bwyd0KZo65Jo

*** Expected check failure: Old-style/bad inputs fail on FreeBSD: /builds/FreeBSD_HEAD/contrib/netbsd-tests/lib/libcrypt/t_crypt.c:140: Test 23 a_Av8awQ0AsR6 != a_C10Dk/ExaG.

*** Expected check failure: Old-style/bad inputs fail on FreeBSD: /builds/FreeBSD_HEAD/contrib/netbsd-tests/lib/libcrypt/t_crypt.c:140: Test 24 ~▒UZoIyj/Hy/c != ~▒.5OTsRVjwLo

</system-err>
</testcase>
"""

There is an issue and a PR for kyua for this:

https://github.com/jmmv/kyua/issues/136
https://github.com/jmmv/kyua/pull/148

Escape these characters is a way, or we might make our test cases always
produce printable characters in outputs, however that might be
impossible (who knows when test fails would happen?).  Or, don't know if
there is a method to embedded these bytes into a valid XML.



Li-Wen

-- 
Li-Wen Hsu <lwhsu_at_FreeBSD.org>
http://lwhsu.org