Re: dtc(1): reproducible segmentation fault

From: David Chisnall <theraven_at_FreeBSD.org>
Date: Sun, 25 Oct 2015 15:00:25 +0000
On 25 Oct 2015, at 00:07, George Abdelmalik <gabdelmalik_at_uniridge.com.au> wrote:
> 
> You've beaten me to it with the fix before I could lodge the bug report :)
> 
> In your repo I've seen that the mmap(2) call now takes the MAP_PRIVATE flag. I
> applied that change locally to my source tree and that has fixed the problem.
> I've since re-read the mmap(2) man page to find out how that change could
> be influential...
> 
>     [EINVAL]           None of MAP_ANON, MAP_PRIVATE, MAP_SHARED, or
>                        MAP_STACK was specified.  At least one of these flags
>                        must be included.
> 
> Although obvious to me now, I missed it on my previous reads.
> 
> Thanks for your assistance. I look forward to your coming set of changes. In
> my view DTC is an important tool and I would be willing contribute effort to
> making it feature parity with the GPL version if that is lacking.

It’s now committed (r289935).  Sorry for the delay - I meant to commit the changes in January and it slipped down my to-do list.

Please do test with any dts files that you have.  If you find bugs, then please report them and assign them to me.

David
Received on Sun Oct 25 2015 - 14:00:43 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:00 UTC