Re: CURRENT: net/igb broken

On Mon, 21 Sep 2015 21:13:18 +0000
Eric Joyner <ricera10_at_gmail.com> wrote:

> If you do a diff between r288057 and r287761, there are no differences
> between the sys/dev/e1000, sys/modules/em, and sys/modules/igb directories.
> Are you sure r287761 actually works?

I'm quite sure r287761 works (and r287762 doesn't), double checked this this
morning again. I also checked r288093 and it is still not working.

The ensure that I'm not the culprit and stupid here:

I use a NanoBSD environment and the only thing that gets exchanged, is the
underlying OS/OS revision. The configuration always stays the same. The base
system for all of my tests is built from a clean source - (deleted obj/ dir,
clean, fresh build into obj/ for every test I ran).

I realised a funny thing. Playing around with enabling/disabling TSO (I have
been told that could be the culprit in an earlier Email from this list) with the
commend sequence:

ifconfig igb1 down
ifconfig igb1 -tso
ifconfig igb1 up
ifconfig igb1 down
ifconfig igb1 tso
ifconfig igb1 up
.
.
.

while a ping is pinging in the background a remote host connected to that
specific interface, the ping does work for a while and dies then after a round
trip of roughly 10 - 20. I can reproduce this.

is that observation of any help?

Regards,

oh

> 
> On Mon, Sep 21, 2015 at 1:58 AM O. Hartmann <ohartman_at_zedat.fu-berlin.de>
> wrote:
> 
> > On Sat, 19 Sep 2015 11:23:44 -0700
> > Sean Bruno <sbruno_at_freebsd.org> wrote:
> >
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA512
> > >
> > >
> > >
> > > On 09/18/15 10:20, Eric Joyner wrote:
> > > > He has an i210 -- he would want to revert e1000_i210.[ch], too.
> > > >
> > > > Sorry for the thrash Sean -- it sounds like it would be a good idea
> > > > for you should revert this patch, and Jeff and I can go look at
> > > > trying these shared code updates and igb changes internally again.
> > > > We at Intel really could've done a better job of making sure these
> > > > changes worked across a wider variety of devices.
> > > >
> > > > - Eric
> > >
> > > I've reverted the changes to head.  I'll reopen the reviews and we can
> > > proceed from there.
> > >
> > > sean
> > >
> > >
> > > >
> > > > On Fri, Sep 18, 2015 at 9:50 AM Sean Bruno <sbruno_at_freebsd.org
> > > > <mailto:sbruno_at_freebsd.org>> wrote:
> > > >
> > > >
> > > >>
> > > >> r287762 broke the system
> > > >
> > > >
> > > > Before I revert this changeset *again* can you test revert r287762
> > > > from if_igb.c, e1000_82575.c and e1000_82575.h *only*
> > > >
> > > > That narrows down the change quite a bit.
> > > >
> > > > sean _______________________________________________
> > > > freebsd-current_at_freebsd.org <mailto:freebsd-current_at_freebsd.org>
> > > > mailing list
> > > > https://lists.freebsd.org/mailman/listinfo/freebsd-current To
> > > > unsubscribe, send any mail to
> > > > "freebsd-current-unsubscribe_at_freebsd.org
> > > > <mailto:freebsd-current-unsubscribe_at_freebsd.org>"
> > > >
> > > -----BEGIN PGP SIGNATURE-----
> > > Version: GnuPG v2
> > >
> > > iQF8BAEBCgBmBQJV/agsXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
> > > ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx
> > > MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kkkMH/icGgcIAdm3CIxtXtnhbE5E9
> > > N6RrBrgJruoRHP2geJ9UOUGp7MaFwS6AHcwCC7FvxoydzcsT+iMj3Kreu+aEkT4C
> > > PZvLsqIvLeX0WVEXSC8jwBAZbrOwJ+4TcMMnW2KZMeUPUHAd8rP0+Skj9AeQ4feJ
> > > OfLqv52VdxYTnx+vYbvZSaOgWp8sC+PcoJxiJua7hpmqXwISbcG9eXxQHUil0fcv
> > > tqfb2dv89VN12brFuQbFtgEK2RG6gKtbj7IQkeQqzt0g5WL6UnJ5OslajcEJwIA4
> > > H6H4eke5CQUugVTUv5cbCwmQDfAF2qF8JgsxuuQDPvQRb4+XH1ks/5SEhENItv0=
> > > =JTMu
> > > -----END PGP SIGNATURE-----
> >
> > I'm now on r288057 on that specific machine, supposedly reverted changes
> > that
> > seemingly has been identified as the culprit. Still NO change in behaviour!
> >
> > r287761 works with the same configuration on igb (i210), any further does
> > not.
> > Not ping/connect from the outside, no ping/connect from the inside. Tried
> > different protocols (SAMBA, ssh, LDAP, DNS). Affected is/are only boxes
> > with
> > the igb driver and i210 chipset (we do not have other chips covered by
> > igb).
> >
> > Regards,
> > Oliver
> >
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"