Re: dumpdev in loader.conf vs rc.d/dumpon

From: Conrad Meyer <cem_at_FreeBSD.org>
Date: Wed, 23 Sep 2015 09:44:04 -0700
On Wed, Sep 23, 2015 at 9:05 AM, Andriy Gapon <avg_at_freebsd.org> wrote:
> On 23/09/2015 18:59, Conrad Meyer wrote:
>> On Wed, Sep 23, 2015 at 7:37 AM, Andriy Gapon <avg_at_freebsd.org> wrote:
> Because that's how I read the code in sys/geom/geom_dev.c.  Especially
> init_dumpdev() - I believe that devtoname() returns a device name without '/dev/'.

I don't think that's the primary use of the variable.

>> I don't see etc/rc.d/dumpon prepending /dev to anything.
>
> Right, that's why I posted my message (bug report).

I think the use of the variable "dumpdev" in GEOM probably
could/should be dropped.

Alternatively (perhaps it is a mechanism for collecting crash dumps
before init / /etc/rc start?) the GEOM dumpdev code could skip over a
"/dev/" prefix when comparing against devname(), so that the GEOM use
of the variable matches the etc/rc.d/dumpon use of the variable.

Best,
Conrad
Received on Wed Sep 23 2015 - 14:44:07 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:59 UTC