Re: Acer C720 crash at boot

From: Wolfgang Zenker <wolfgang_at_lyxys.ka.sub.org> Date: Sat, 9 Apr 2016 18:42:26 +0200 · This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:04 UTC

Hi,

system does not crash with this patch, thanks!

* John Baldwin <jhb_at_freebsd.org> [160409 17:27]:
> On Saturday, April 09, 2016 05:25:35 PM Konstantin Belousov wrote:
>> On Sat, Apr 09, 2016 at 03:27:46PM +0200, Wolfgang Zenker wrote:
>>> Done: http://cid2945g797.hs14.hosting.punkt.de/IMG_3762.JPG

>> The immediate cause was the change in r297466, but the code that existed
>> there, did not worked.  It looks as a bug in ichiic, set_controller()
>> use msleep() with timeout too early when compiled into the kernel.

> Can you try this change:

> diff --git a/sys/dev/ichiic/ig4_iic.c b/sys/dev/ichiic/ig4_iic.c
> index a556127..23bdb7d 100644
> --- a/sys/dev/ichiic/ig4_iic.c
> +++ b/sys/dev/ichiic/ig4_iic.c
> _at__at_ -117,7 +117,10 _at__at_ set_controller(ig4iic_softc_t *sc, uint32_t ctl)
>  			error = 0;
>  			break;
>  		}
> -		mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1);
> +		if (cold)
> +			DELAY(1000);
> +		else
> +			mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1);
>  	}
>  	return (error);
>  }

Wolfgang