Re: CFR: extend use of nitems() macro in the kernel.

From: Conrad Meyer <cem_at_FreeBSD.org>
Date: Sat, 16 Apr 2016 16:08:22 -0700
On Sat, Apr 16, 2016 at 11:25 AM, Pedro Giffuni <pfg_at_freebsd.org> wrote:
> Hello;
>
> Using coccinelle, and some hand re-formatting, I generated a patch to
> make use of the nitems() macro in sys, which is too big for
> phabricator [1].
>
> I was careful to exclude anything from the contrib directory or
> any code that is shared with userland (as to not have to include
> additional headers).
>
> The patch is big but pretty safe, I think. The changes are small but
> still it touches many files[1].
>
> I would like some feedback on the convenience of doing such replacement.
> If it is a good idea we could do the same for roundup2() and, in fact,
> I think DragonFly has already done this.

Assuming this change is correct, I am all for it.

Assuming roundup2()s can be cleaned up in an automated and correct
way, I am all for that sort of mechanical change too.

Best,
Conrad
Received on Sat Apr 16 2016 - 21:38:55 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:04 UTC