Re: SVN r303643 breaks non-SMP compilation

From: Guido Falsi <mad_at_madpilot.net>
Date: Tue, 2 Aug 2016 16:52:45 +0200
On 08/02/16 05:06, Mateusz Guzik wrote:
> On Mon, Aug 01, 2016 at 09:49:03PM -0400, Michael Butler wrote:
>> In the non-SMP case, ADAPTIVE_MUTEXES is not defined and a subsequent
>> reference to mtx_delay causes compilation of kern_mutex.c to fail
>> because KDTRACE_HOOKS may be,
>>
> 
> Indeed, fixed in r303655.
> 
> Thanks for reporting.
> 

I've noticed another failure in the same file, caused by r303643.

It's failing to compile here due to errors about SYSINIT(9), it looks
like #include <sys/kernel.h> is missing.

I have made a local patch which compiles and afdter a reboot seems to
work fine:

Index: head/sys/kern/kern_sx.c
===================================================================
--- head/sys/kern/kern_sx.c	(revision 303658)
+++ head/sys/kern/kern_sx.c	(working copy)
_at__at_ -58,6 +58,7 _at__at_

 #if defined(SMP) && !defined(NO_ADAPTIVE_SX)
 #include <machine/cpu.h>
+#include <sys/kernel.h>
 #endif

 #ifdef DDB


-- 
Guido Falsi <mad_at_madpilot.net>
Received on Tue Aug 02 2016 - 12:52:57 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:07 UTC