Re: Missingly recognized ADA_Q_NCQ_TRIM_BROKEN for Crucial M550 MU02

Hi.

On Tue, 16 Aug 2016 13:48:40 -0600
Warner Losh <imp_at_bsdimp.com> wrote:

> What does camcontrol devlist say? I'm guessing firmware MU02, but I
> want to make sure...

% camcontrol devlist   
<Crucial CT1024M550SSD1 MU02>      at scbus0 target 0 lun 0 (ada0,pass0)
<Samsung SSD 850 EVO 250GB EMT01B6Q>  at scbus1 target 0 lun 0
(ada1,pass1) <AHCI SGPIO Enclosure 1.00 0001>   at scbus4 target 0 lun
0 (ses0,pass2)

Above includes another drive and ses0.
Another drive is recongized properly.

ada1 at ahcich1 bus 0 scbus1 target 0 lun 0
ada1: <Samsung SSD 850 EVO 250GB EMT01B6Q> ACS-2 ATA SATA 3.x device
ada1: Serial Number ***************
ada1: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 512bytes)
ada1: Command Queueing enabled
ada1: 238475MB (488397168 512 byte sectors)
ada1: quirks=0x3<4K,NCQ_TRIM_BROKEN>
Steering write from 0 kBps to 300000 kBps

Samsung consumer SSD should have 4k and NCQ_TRIM_BROKEN quirk, and
recognized so.


> It shouldn't match this one. The MU07 exception works for my M500's,
> so I'm confused...

Me too very confused. :-(
This shouldn't happen with this code path.


> Please file a bugzilla ticket.

Found already filed PR for other model while attempting to file one.

  Bug 210686 - NCQ_TRIM_BROKEN quirk mismatch 
  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210686

Please work on it. (So do I.)

I've not yet tested the proposed patch (found just now), but will test
later and add feedback to it.

> 
> Warner
> 
> On Tue, Aug 16, 2016 at 8:01 AM, Tomoaki AOKI <junchoon_at_dec.sakura.ne.jp> wrote:
> > Hi.
> >
> > I noticed that my Crucial M550 SSD (firmware MU02) is missingly
> > recognized as quirk ADA_Q_NCQ_TRIM_BROKEN.
> > If I understand the source (introduced first at r298002, before
> > stable/11 branched) correctly, only firmware MU01 should be recognized
> > so for the SSD model, so I have no idea why. :-(
> >
> > Below are the related portion of dmesg. stable/11 at r304189, amd64.
> > (Built with options CAM_IOSCHED_DYNAMIC.)
> >
> >   ada0 at ahcich0 bus 0 scbus0 target 0 lun 0
> >   ada0: <Crucial CT1024M550SSD1 MU02> ACS-2 ATA SATA 3.x device
> >   ada0: Serial Number ************
> >   ada0: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes)
> >   ada0: Command Queueing enabled
> >   ada0: 976762MB (2000409264 512 byte sectors)
> >   ada0: quirks=0x2<NCQ_TRIM_BROKEN>
> >   Steering write from 0 kBps to 300000 kBps
> >
> > One thing to note: The SSD was shipped with MU01 and updated to MU02
> > using CD image obtained from Crucial Japan website.
> >
> > Need Bugzilla ticket although it's not a severe problem (goes safer
> > side, and easy to workaround via loader.conf)?
> >
> > --
> > Tomoaki AOKI    <junchoon_at_dec.sakura.ne.jp>
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
> 


-- 
Tomoaki AOKI    <junchoon_at_dec.sakura.ne.jp>