Re: make universe and /etc/src.conf

On Mon, Aug 22, 2016 at 08:47:06AM -0700, Bryan Drewery wrote:
> On 8/22/2016 8:27 AM, Glen Barber wrote:
> > On Mon, Aug 22, 2016 at 10:24:25AM -0500, Eric van Gyzen wrote:
> >> I just tried a "make universe", and all the kernels failed because they couldn't
> >> find the config files.  I had forgotten that I have this in /etc/src.conf:
> >>
> >> 	KERNCONF=NUMA
> >> 	KERNCONFDIR=/etc
> >>
> >> Since "make universe" is primarily used for build-testing changes in src,
> >> shouldn't it ignore /etc/src.conf (and possibly /etc/src-env.conf), like the
> >> following?  Or is "make universe" used for other purposes for which it really
> >> should read /etc/src*.conf?
> 
> I disagree. Universe has read src.conf for a long time, and not
> make.conf which is more system-specific.  Perhaps you should move your
> KERNCONF* to make.conf.
> 

Ah, thank you, I missed the configuration file mentioned above.

> >>
> >> --- Makefile	(revision 304226)
> >> +++ Makefile	(working copy)
> >> _at__at_ -479,6 +479,7 _at__at_
> >>  universe_${target}_${target_arch}: universe_${target}_prologue .MAKE .PHONY
> >>  	_at_echo ">> ${target}.${target_arch} ${UNIVERSE_TARGET} started on `LC_ALL=C date`"
> >>  	_at_(cd ${.CURDIR} && env __MAKE_CONF=/dev/null \
> >> +	    SRCCONF=/dev/null SRC_ENV_CONF=/dev/null \
> >>  	    ${SUB_MAKE} ${JFLAG} ${UNIVERSE_TARGET} \
> >>  	    TARGET=${target} \
> >>  	    TARGET_ARCH=${target_arch} \
> >>
> > 
> > I'm CC-ing bdrewery_at_ who did a bunch of /etc/src-env.conf work.  I don't
> > *think* it was supposed to be required.  I might be wrong, though.
> > 
> 
> This isn't src-env-specific though.
> 

Indeed, thank you for the prompt reply.

Glen