SVN r310931 Bad code

From: Michael Butler <imb_at_protected-networks.net>
Date: Sat, 31 Dec 2016 09:14:52 -0500
At line 1949 of head/contrib/bsnmp/lib/snmpclient.c, you changed ..

-		if ((sc->chost = malloc(strlen(s) + 1)) == NULL) {
+		if ((sc->chost = strdup(strlen(s))) == NULL) {

This can't work as intended since strlen returns the length of the
string not a pointer to it.

I expect this should be ..

		if ((sc->chost = strdup(s)) == NULL) {

	Michael
Received on Sat Dec 31 2016 - 13:15:02 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:09 UTC