Re: thread-unsafety problems as spl*() ones are NOP

From: Slawa Olhovchenkov <slw_at_zxy.spb.ru>
Date: Sat, 30 Jan 2016 21:02:56 +0300
On Sat, Jan 30, 2016 at 06:56:00PM +0330, mokhi wrote:

> Hi.
> in kbd.c there are many places spltty()/splx() used assuming it locks/unlocks.
> though there is bug filed for this, and ive asked in #bsddev, Ive
> preferred to ask and ensure it from here again.
> As these functions are obsoleted now, this assumption is incorrect and
> some places we have thread-unsafely which leads to security problems
> (and/or for example double-free, etc)
> 
> can i use mutex/spin/lock/unlock under where assumed a lock/unlock by
> using spltty()/splx() to patch it?

If other parts of kernel sources, locked by spltty()/splx(), don't
interacted by called function and accessed data.

Cuurently, in stable, spltty used in 27 files and splx in 101 files.
Received on Sat Jan 30 2016 - 17:03:06 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:02 UTC