Re: clang 3.3/3.4 fails to build items that use stdlib.h because of __alloc_size attribute assigned to posix_memalign

From: Pedro Giffuni <pfg_at_FreeBSD.org>
Date: Tue, 5 Jul 2016 15:55:12 -0500
Answering to myself ....

On 07/05/16 15:24, Pedro Giffuni wrote:
> Hmm ...
>
> On 07/05/16 15:14, Conrad Meyer wrote:
>> Whoops, missed reply-all the first time.
>>
>> It seems pretty clear that alloc_size (return value is a memory
>> allocation of size from parameter N) does not apply to posix_memalign,
>> because posix_memalign's allocation is stored via a pointer argument
>> rather than return value.
>>
>> https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes
>>
>>
>> IMO the attribute should be removed from posix_memalign in stdlib.h
>>
>> Best,
>> Conrad
>>
>
> - I am wondering why it hasn't affected -current if it is wrong.

Because newer clang removed alloc_size altogether.

> - I am also wondering if we shouldn't just get rid of the attribute.
>

Nah, it is basically meant for FORTIFY_SOURCE, which is not being
worked on anymore but maybe handy some day.

> I will answer to myself those doubts and fix the issue. Thanks!
>

So, yes, we should remove it from posix_memalign(). I'll ask re_at_.

Pedro.
Received on Tue Jul 05 2016 - 18:55:14 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:06 UTC