Re: BBB (cpsw(4)) seems to be broken in the latest 11-current

Luiz, the patch works for me beautifully. Has not been able to reproduce
the issue since applying it. Can you please merge it before 11.0 gets
branched? Thanks!

-Max

On Tue, Jun 21, 2016 at 10:33 AM, Paul Mather <paul_at_gromit.dlib.vt.edu>
wrote:

> On Jun 20, 2016, at 6:33 PM, Keith White <kwhite_at_site.uottawa.ca> wrote:
>
> > On Mon, 20 Jun 2016, Luiz Otavio O Souza wrote:
> >
> >> On Sun, Jun 19, 2016 at 1:11 AM, Maxim Sobolev wrote:
> >>> Jim, some update from here. Running r283287 of the driver, I still see
> the
> >>> same "watchdog timeout" messages, but they do not lead to the interface
> >>> lockout. The traffic resumes momentarily. Which is probably why I
> never paid
> >>> much attention to those warnings before. Therefore, I suspect that the
> new
> >>> MAC code does not deal with watchdog-triggered interface reset as good
> as
> >>> the old code. Does it give you any ideas about what could be wrong
> there by
> >>> any chance?
> >>
> >>
> >> Hi Maxim,
> >>
> >> My recent changes contributed somehow to expose the bug more frequently.
> >>
> >> There was a condition in tx packet reclamation where we aren't
> >> restarting the tx queue in one of the possible stall conditions.
> >>
> >> Please try the attached patch and let me know if it works for you.
> >>
> >> Luiz
> >
> > Your patch fixes the problem for me.  Thanks!
> >
> > FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #0 r302028M: Mon Jun
> 20 18:19:55 EDT 2016     kwhite_at_freebsd11:/usr/obj/arm.armv6/usr/src/sys/BEAGLEBONE-LOCAL
> arm armv6
> >
> > ...keith
>
>
> The patch also fixes the problem for me.
>
> FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #2 r302030M: Tue Jun 21
> 10:20:59 EDT 2016     pmather_at_beaglebone:/usr/obj/usr/src/sys/BEAGLEBONE-NO_WITNESS
> arm
>
>
> Cheers,
>
> Paul.
>
>