Re: resolvconf needs _at_RESTARTCMD_at_ to be replaced after r303062

From: Pedro Giffuni <pfg_at_FreeBSD.org>
Date: Sat, 30 Jul 2016 20:40:02 -0500
(CC'ing Glen for review, since he was the last to touch that file and
may know better).

Hi Guy;


On 07/30/16 17:37, Guy Yur wrote:
> Hi,
>
> openresolv 3.8.1 added RESTARTCMD=_at_RESTARTCMD_at_ in
> contrib/openresolv/resolvconf.in.
> It is not replaced by the sed expressions in sbin/resolvconf/Makefile.
>
> Error seen is "eval: _at_RESTARTCMD_at_: not found".
>
> Current _at_RESTARTCMD \(.*\)_at_ sed expression needs to be kept for
> pdns_recursor.in and a new expression added to replace _at_RESTARTCMD_at_.
>

I see, you mean here:

https://svnweb.freebsd.org/base/head/sbin/resolvconf/Makefile?revision=298107&view=markup#l32

> The following worked for me:
> RESTARTCMD_=    "/usr/sbin/service \\$$1 onestatus >/dev/null 2>\&1
> \&\& /usr/sbin/service \\$$1 restart"
>
> sed ... \
>   ... \
>   -e 's:_at_RESTARTCMD_at_:${RESTARTCMD_}:g' \
>   ...

And perhaps something like the attached patch (is the underscore
a typo?).

I don't see the error message though. so I need some confirmation that
this fixes the issue.

Pedro.

Received on Sat Jul 30 2016 - 23:40:00 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:07 UTC