Re: resolvconf needs _at_RESTARTCMD_at_ to be replaced after r303062

On Sun, Jul 31, 2016 at 5:46 AM, Pedro Giffuni <pfg_at_freebsd.org> wrote:
>
>
>>> Index: sbin/resolvconf/Makefile
>>> ===================================================================
>>> --- sbin/resolvconf/Makefile    (revision 303557)
>>> +++ sbin/resolvconf/Makefile    (working copy)
>>> _at__at_ -30,6 +30,7 _at__at_
>>>                 -e 's:_at_LIBEXECDIR_at_:${FILESDIR}:g' \
>>>                 -e 's:_at_VARDIR_at_:${VARDIR}:g' \
>>>                 -e 's:_at_RESTARTCMD \(.*\)_at_:${RESTARTCMD}:g' \
>>> +               -e 's:_at_RESTARTCMD_at_:${RESTARTCMD}:g' \
>>>                 -e 's:_at_RCDIR_at_:${RCDIR}:g' \
>>>                 -e 's: vpn : ng[0-9]*&:g' \
>>>                 ${DIST}/$_at_.in > $_at_
>>
>>
>
> And the underscore was not a typo.
> Thanks Guy!
>
> Pedro.

Hi,

I meant for the RESTARTCMD_= statement to be added too.
I should have sent a patch file.

Issue could be seen during boot if using dhcpcd which invokes resolvconf
or by running 'resolvconf -r SERVICENAME'

With r303567, RESTARTCMD is now empty in the script so
dynamic detection for service command is done.

Attaching new patch.

1.
Renaming RESTARTCMD, CMD1, CMD2 to _WITH_ARG since it is only
used by pdns_recursor.in.
The other files have all moved to use $RESTARTCMD passed from resolvconf.

I will send a patch upstream to do the same for pdns_recursor.in.
The ugly _WITH_ARG vars can be removed when pdns_recursor.in
is updated to new style.

2.
Renaming RESTARTCMD_ to RESTARTCMD and adding the lines for
new CMD1, CMD2, RESTARTCMD statements.


Thanks,
Guy