Re: 11.0 -r300944 build*KERNEL* via amd64-gcc fails for: .../dev/cxgb/ulp/tom/cxgb_listen.c:926:13: error: redundant redeclaration of 'tcp_dooptions'; cxgbe has an issue too

On 2016-Jun-1, at 12:36 AM, Navdeep Parhar <nparhar at gmail.com> wrote:

> On Tue, May 31, 2016 at 10:49:29PM -0700, Mark Millard wrote:
>> On 2016-May-31, at 10:31 PM, Mark Millard <markmi at dsl-only.net> wrote:
>> 
> <snip>
>> 
>> If the offending declaration in cxgb_listen.c is commented out (or removed)
>> there is a "next problem" but for cxgbe:
>> 
>>> --- all_subdir_cxgbe/tom ---
>>> /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c: In function 'do_pass_accept_req':
>>> /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:640:1: warning: inlining failed in call to 'release_synqe': call is unlikely and code size would grow [-Winline]
> 
> Can you try removing the "inline" at line 639 in t4_listen.c and see if that
> makes a difference?
> 
> Regards,
> Navdeep

I tried commenting out the inline.

Looks like cxgbe code has the same sort of redundant declaration problem as cxgb code:

> --- t4_listen.o ---
> /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:669:13: error: redundant redeclaration of 'tcp_dooptions' [-Werror=redundant-decls]
>  extern void tcp_dooptions(struct tcpopt *, u_char *, int, int);
>              ^
> In file included from /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:61:0:
> /usr/src/sys/netinet/tcp_var.h:769:7: note: previous declaration of 'tcp_dooptions' was here
>  void  tcp_dooptions(struct tcpopt *, u_char *, int, int);
>        ^

. . .
> --- t4_listen.o ---
> cc1: all warnings being treated as errors
> *** [t4_listen.o] Error code 1

Commenting that out as well lead to a failure in a very different area of code:

> --- all_subdir_drm2/i915kms ---
> In file included from /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_drv.h:31:0,
>                  from /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo.h:35,
>                  from /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo_ch7xxx.c:32:
> /usr/src/sys/dev/drm2/i915/i915_drv.h:1621:6: error: redundant redeclaration of 'i915_gem_dump_object' [-Werror=redundant-decls]
>  void i915_gem_dump_object(struct drm_i915_gem_object *obj, int len,
>       ^
> /usr/src/sys/dev/drm2/i915/i915_drv.h:1612:6: note: previous declaration of 'i915_gem_dump_object' was here
>  void i915_gem_dump_object(struct drm_i915_gem_object *obj, int len,
>       ^
> In file included from /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo.h:35:0,
>                  from /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo_ch7xxx.c:32:
> /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_drv.h:671:13: error: redundant redeclaration of 'intel_fbc_enabled' [-Werror=redundant-decls]
>  extern bool intel_fbc_enabled(struct drm_device *dev);
>              ^
> In file included from /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_drv.h:31:0,
>                  from /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo.h:35,
>                  from /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo_ch7xxx.c:32:
> /usr/src/sys/dev/drm2/i915/i915_drv.h:1676:13: note: previous declaration of 'intel_fbc_enabled' was here
>  extern bool intel_fbc_enabled(struct drm_device *dev);
>              ^

. . .
> --- all_subdir_drm2 ---
> cc1: all warnings being treated as errors
> *** [dvo_ch7xxx.o] Error code 1


===
Mark Millard
markmi at dsl-only.net