Re: svn commit: r301394 - head [If X_COMPILER_TYPE is defined, do not use it, otherwise use it?]

From: Bryan Drewery <bdrewery_at_FreeBSD.org>
Date: Sat, 4 Jun 2016 10:38:33 -0700
On 6/4/2016 10:35 AM, Mark Millard wrote:
> From the commit report:
> 
>> +.if defined(X_COMPILER_TYPE)
>>  CROSSENV+=	COMPILER_VERSION=${COMPILER_VERSION} \
>>  		COMPILER_TYPE=${COMPILER_TYPE} \
>>  		COMPILER_FREEBSD_VERSION=${COMPILER_FREEBSD_VERSION}
> 
> This does not use X_COMPILER_TYPE when it is defined.
> 
>> +.else
>> +CROSSENV+=	COMPILER_VERSION=${X_COMPILER_VERSION} \
>> +		COMPILER_TYPE=${X_COMPILER_TYPE} \
>> +		COMPILER_FREEBSD_VERSION=${X_COMPILER_FREEBSD_VERSION}
> 
> This tries to use the undefined X_COMPILER_TYPE.
> 
>> +.endif
> 
> 
> 
> Overall:
> 
> A not seems to be missing or instead the nested code blocks need to be swapped.
> 

I'm an idiot, thanks.


-- 
Regards,
Bryan Drewery


Received on Sat Jun 04 2016 - 15:38:29 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:05 UTC