Re: 11.0 -r301815 to -r310873 using WITH_META_MODE=yes : an empty filename failure

On 6/13/16 7:56 PM, Bryan Drewery wrote:
> On 6/13/2016 7:26 PM, Mark Millard wrote:
>> [The following is after the svnltie update -r301873 /usr/src .]
>>
>> For the following in a amd64 rebuild on amd64 (a WITH_META_MODE=yes buidlworld buidlkernel just after a without meta mode buildworld buildkernel [no install]). . .
>>
>>> # more sys/modules/drm2/radeonkmsfw/Makefile.inc 
>>> # $FreeBSD: head/sys/modules/drm2/radeonkmsfw/Makefile.inc 254885 2013-08-25 19:37:15Z dumbbell $
>>> #
>>> # Common rules for building firmware.  Note this gets auto-included
>>> # by the subdir Makefile's as a consequence of included bsd.kmod.mk.
>>>
>>> _FIRM=  ${IMG}.bin
>>>
>>> CLEANFILES+=    ${_FIRM}
>>>
>>> FIRMWS= ${_FIRM}:${KMOD}
>>>
>>> #
>>> # Note that a license ack is not needed for iwn.
>>> #
>>> #FIRMWARE_LICENSE=
>>>
>>> ${_FIRM}: ${.CURDIR}/../../../../contrib/dev/drm2/radeonkmsfw/${_FIRM}.uu
>>>         uudecode -p $? > ${.TARGET}
>>
>>
>> I just had . . .
>> (Note the uudecode line in the .meta file, the reference to stdin, and the resultant "begin" line error.)
>>
>>> # more /usr/obj/clang/amd64.amd64/usr/src/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/drm2/radeonkmsfw/ARUBA_me/ARUBA_me.bin.meta 
>>> # Meta data file /usr/obj/clang/amd64.amd64/usr/src/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/drm2/radeonkmsfw/ARUBA_me/ARUBA_me.bin.meta
>>> CMD uudecode -p  > ARUBA_me.bin
>>> CWD /usr/obj/clang/amd64.amd64/usr/src/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/drm2/radeonkmsfw/ARUBA_me
>>> TARGET ARUBA_me.bin
>>> -- command output --
>>> uudecode: stdin: missing or bad "begin" line
>>> *** Error code 1
>>>
>>> -- filemon acquired metadata --
>>> # filemon version 5
>>> # Target pid 7146
>>> # Start 1465867565.855820
>>> V 5
>>> E 7163 /bin/sh
>>> R 7163 /etc/libmap.conf
>>> R 7163 /var/run/ld-elf.so.hints
>>> R 7163 /lib/libedit.so.7
>>> R 7163 /lib/libc.so.7
>>> R 7163 /lib/libncursesw.so.8
>>> F 7163 7164
>>> W 7164 ARUBA_me.bin
>>> E 7164 /usr/bin/uudecode
>>> R 7164 /etc/libmap.conf
>>> R 7164 /var/run/ld-elf.so.hints
>>> R 7164 /lib/libc.so.7
>>> X 7164 1 0
>>> X 7163 1 0
>>> # Stop 1465867565.868045
>>> # Bye bye
>>
>>
> 
> I don't know what's going on here at first glance but it doesn't look
> related to META_MODE.  I'm not too familiar with $?.
> 

Actually it does seem to be meta-missing bug since $? (.OODATE) is empty
and yet it is requiring a .meta file.

Easy way to recreate it:

cd sys/modules/drm2/radeonkmsfw/ARUBA_me
make cleandir
make obj
make
make -dM # it notes that ARUBA_me.bin cannot be compared due to .OODATE
rm $(make whereobj)/ARUBA_me.bin.meta
make -dM

> /usr/obj/root/git/freebsd/sys/modules/drm2/radeonkmsfw/ARUBA_me/ARUBA_me.bin.meta: required but missing
> Building /usr/obj/root/git/freebsd/sys/modules/drm2/radeonkmsfw/ARUBA_me/ARUBA_me.bin
> 
> load: 17.72  cmd: uudecode 86777 [ttyin] 9.98r 0.00u 0.00s 0% 2052k




-- 
Regards,
Bryan Drewery