On 2016-Jun-14, at 6:48 PM, Bryan Drewery <bdrewery at FreeBSD.org> wrote: > On 6/14/2016 5:13 PM, Mark Millard wrote: >>> The targets (at top-level) that META_MODE is applied to is a whitelist >>> now after r301887. So it's safe to always pass it when building from >>> the top-level. If it's an unsupported target it will internally disable >>> META_MODE. >> So WITH_META_MODE=yes is now always allowed. That still leaves the questions of when WITH_META_MODE=yes is necessary: For example, is it ever required for the likes of mergemaster? (I'll use mergemaster to illustrate a more general question that applies to other potential scripts as well.) > > There is no point to provide it to mergemaster or for it to use it > internally. The recommended way to use this feature is to add it to > /etc/src-env.conf and forget about it or specify it for > buildworld/buildkernel/universe (build) targets. There is also no harm > in always defining it. That is the goal at least. > > -- > Regards, > Bryan Drewery Okay. Thanks for the information. I asked in part because mergemaster [as an example] has code like: > # grep -i make /usr/sbin/mergemaster | more . . . > MM_MAKE="make ${ARCHSTRING} -m ${SOURCEDIR}/share/mk" . . . > ${MM_MAKE} _obj SUBDIR_OVERRIDE=etc >/dev/null && . . . > ${MM_MAKE} everything SUBDIR_OVERRIDE=etc >/dev/null && . . . and "_obj" and "everything" overlap with the latest whitelist edit: > META_TGT_WHITELIST+= \ > _* build32 buildfiles buildincludes buildkernel buildsoft \ > buildworld everything kernel-toolchains kernels libraries \ > - native-xtools tinderbox toolchain toolchains universe worlds \ > - xdev xdev-build > + native-xtools showconfig tinderbox toolchain toolchains universe \ > + worlds xdev xdev-build but in mergemaster are just specifically for SUBDIR_OVERRIDE=etc . === Mark Millard markmi at dsl-only.netReceived on Wed Jun 15 2016 - 00:17:03 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:05 UTC