Re: SM bus ioctls incorrect in FreeBSD 11

From: Adrian Chadd <adrian.chadd_at_gmail.com>
Date: Thu, 10 Nov 2016 08:05:51 -0800
+10 on option 2. Hate to say it, but I'd rather this little corner of
freebsd be "right" before it gets more heavily used.


-a


On 10 November 2016 at 03:21, Andriy Gapon <avg_at_freebsd.org> wrote:
> On 14/10/2016 18:51, Lewis Donzis wrote:
>> Our opinion doesn’t count for much, but I like 2 or 4.  Option 1 would
>> essentially obviate the entire purpose of changing the structure.  Option 2
>> basically finishes the job and makes it work properly.  Option 3 is, as you
>> say, unappealing.  I have no problem with Option 4, obviously we can change
>> our code back to the old way, but assuming there was a good reason for this
>> change in the first place, Option 2 seems more logical.
>>
>> But whatever y’all decide is fine with us, we’ll just change code to match at
>> the appropriate time.
>
> Anyone interested in the issue, could you please take a look at this review?
> https://reviews.freebsd.org/D8430
>
> Thank you.
>
> --
> Andriy Gapon
> _______________________________________________
> freebsd-arch_at_freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-arch
> To unsubscribe, send any mail to "freebsd-arch-unsubscribe_at_freebsd.org"
Received on Thu Nov 10 2016 - 15:05:53 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:08 UTC