Re: [request for testing] isl, cyapa on chromebooks

On 06/10/2016 10:25, Andriy Gapon wrote:
> On 06/10/2016 10:08, Michael Gmelin wrote:
>>
>>
>>> On 05 Oct 2016, at 15:01, Andriy Gapon <avg_at_FreeBSD.org> wrote:
>>>
>>>> On 05/10/2016 14:19, Michael Gmelin wrote:
>>>>
>>>> ig4iic_start is called, but iicbus_hinted_child, isl_probe, iicbus_probe and
>>>> iicbus_attach are not.
>>>
>>> Thank you!
>>> Now I think I see where I made a silly mistake.
>>> Please try an updated version of the patch from here
>>> https://people.freebsd.org/~avg/ig4-i2c.v3.diff
>>> It contains a fix and some cosmetic changes on top of the previous patch.
>>>
>>
>> Isl attaches cleanly on iicbus1 now, but it doesn't appear to function (all inputs, like  dev.isl.ir etc, are stuck at 0).
> 
> At least some progress...
> Anything interesting in logs?
> 
> Oh! and I've just spotted a typo in isl.c: the last call to isl_read_byte() in
> isl_read_sensor() should have REG_DATA2 (not REG_DATA1 again).

And another, more severe typo :-(
In isl_read_byte we should pass both messages to the bus:
	return (iicbus_transfer(dev, msgs, 2));
That is, s/1/2/.

-- 
Andriy Gapon