Re: [patch] Improving the 'zpool labelclear' command

From: Ganael LAPLANCHE <martymac_at_FreeBSD.org>
Date: Fri, 30 Sep 2016 09:56:59 -0000
On Thu, 29 Sep 2016 14:13:52 -0400, Ultima wrote

> > In case you are interested, I have posted a patch to improve the 'zpool
> > labelclear' command here :
> >
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204622
> >
> > - force ('-f') will now allow to erase labels, even if they are broken
> > (restoring the behaviour of our previous -FreeBSD- version of
labelclear)
> > - You can select which label you want to erase (beginning, end or
> > specific index)
> > - You can use a 'minimal' mode which will invalidate a label by changing
> > only a single byte. This is useful to minimize the chances to
> > overwrite/destroy a FS that would have been created over the label, but
> > still leaving the label visible.
>
> This patch looks good its too bad the core hasn't looked at it 
> yet. Ill do some testing and report any issues found. Some 
> points you bring up in the bug are quite valid. Thanks for 
> working on this! =]

Thanks. Yes, it would be nice if a src committer could take a look at it.

Any feedback welcome :)

--
Ganael LAPLANCHE <ganael.laplanche_at_martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac_at_FreeBSD.org>, http://www.FreeBSD.org
Received on Fri Sep 30 2016 - 07:56:59 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:08 UTC