Re: buildkernel broken for META_MODE

From: Bryan Drewery <bdrewery_at_FreeBSD.org>
Date: Tue, 18 Apr 2017 16:05:09 -0700
On 4/18/2017 3:26 PM, Simon J. Gerraty wrote:
>>> [Creating objdir /usr/obj/usr/obj/root/git/freebsd/sys/GENERIC...]
>> Wrong^
>>
>> Note we have 'cd /usr/obj/....' and 'MAKEOBJDIRPREFIX=/usr/obj' in
>> there, so we get a nested /usr/obj/.CURDIR problem of /usr/obj/usr/obj.
> 
> The following would probably help that case:
> 
> Index: auto.obj.mk
> ===================================================================
> RCS file: /volume/cvs/sjg/mk/auto.obj.mk,v
> retrieving revision 1.13
> diff -u -p -r1.13 auto.obj.mk
> --- auto.obj.mk	24 Mar 2017 20:53:22 -0000	1.13
> +++ auto.obj.mk	18 Apr 2017 22:25:08 -0000
> _at__at_ -41,6 +41,10 _at__at_ MKOBJDIRS= auto
>  # Use __objdir here so it is easier to tweak without impacting
>  # the logic.
>  .if !empty(MAKEOBJDIRPREFIX)
> +.if ${.CURDIR:M${MAKEOBJDIRPREFIX}/*} != ""
> +# we are already in obj tree!
> +__objdir?= ${.CURDIR}
> +.endif
>  __objdir?= ${MAKEOBJDIRPREFIX}${.CURDIR}
>  .endif
>  __objdir?= ${MAKEOBJDIR:Uobj}
> 

Yes this looks right and fixes buildkernel completely.

-- 
Regards,
Bryan Drewery


Received on Tue Apr 18 2017 - 21:05:36 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:11 UTC