Re: src/libexec/Makefile damaged fails to build rshd

Hi, Reference:
> From:		Ngie Cooper <yaneurabeya_at_gmail.com>
> Date:		Sun, 6 Aug 2017 12:16:21 -0700

Ngie Cooper wrote:
> 
> > On Aug 6, 2017, at 11:38, Julian H. Stacey <jhs_at_berklix.com> wrote:
> > 
> > "Ngie Cooper (yaneurabeya)" wrote:
> >> --Apple-Mail=_7653CBF4-A533-4B1C-8D92-2E3AF5958F08
> >> Content-Transfer-Encoding: 7bit
> >> Content-Type: text/plain;
> >>    charset=us-ascii
> >> 
> >> 
> >>> On Aug 6, 2017, at 09:36, Julian H. Stacey <jhs_at_berklix.com> wrote:
> >>> 
> >>> Hi freebsd-current_at_freebsd.org
> >>> with current src
> >>>    .ctm_status src-cur 13120
> >>>    .svn_revision    322111
> >>> libexec/Makefile has been butchered, eg
> >>> rshd & other builds silently omitted
> >>> unless one debugs & learns to do eg
> >>>    setenv _rshd Something
> >>> A find & grep of src/ shows no other ref. to _rshd except
> >>>    ./libexec/Makefile:     ${_rshd} \
> >>>    ./libexec/Makefile:_rshd=               rshd
> >>> 
> >>> I sampled _pppoed same error !
> >>>    ./libexec/Makefile:     ${_pppoed} \
> >>>    ./libexec/Makefile:_pppoed=     pppoed
> >>> 
> >>> Others turned off are:
> >>>       ${_atf} \ ${_atrun} \ ${_blacklistd-helper} \ ${_comsat} \
> >>>       ${_dma} \ ${_mail.local} \ ${_makewhatis.local} \ ${_mknetid}
> >>>       \ ${_pppoed} \ ${_rlogind} \ ${_rshd} \ ${_rtld-elf} \
> >>>       ${_smrsh} \ ${_telnetd} \ ${_tests} \ ${_tftp-proxy} \ ${_ypxfr}
> >>> 
> >>> If src/ annoyingly insists to force everyone to silently Not build src/,
> >>> there should at least be some switch & reference doc in eg
> >>>    src/share/mk
> >>>    src/share/man/man5/src.conf
> >> 
> >> Julian,
> >>    Could you please post your build error (in its entirety) somewhere?
> >> Thank you,
> >> -Ngie
> > 
> > Why ?  Problem is fully identified.  Please read source.
> > The half baked mod. to src/libexec/Makefile could be backed out
> > as it fails to be supported by src/share/mk & src.conf.
> 
> Hi Julian,
>     The reason why I need more context is that I was unable to repro the issue. I need more details to help isolate/fix the problem.
> Thanks,
> -Ngie

Hi Ngie
OK, In case it was that, after last mail I started a full rebuild
of world inc kernel, having moved aside my make.conf & src.conf but
I forgot to also unsetenv all my vars, so after that's installed I'll do a
script & unsetenv all & make all.  That will take a day to get back to you.

But it wont change anything.
Meantime please read /usr/src I't's Insufficient.

Maybe reason you cant replicate problem is because you have an environment or
src.conf or make,conf (or something else) Maybe a Makefile.local or ?
that defines _rshd as rshd ?
Only someone lucky enough to have that will install a new /usr/libexec/rshd

Try this:

diff -c Makefile makefile.jhs
*** Makefile    Sun Aug  6 21:39:51 2017
--- makefile.jhs        Sun Aug  6 21:38:52 2017
***************
*** 114,119 ****
--- 114,122 ----
  _tests=               tests
  .endif
  
+ xx:
+       echo "SUBDIR is ${SUBDIR}"
+ 
  .include <bsd.arch.inc.mk>
  
  .include <bsd.subdir.mk>

make -f makefile.jhs xx
echo "SUBDIR is atf atrun blacklistd-helper comsat dma getty mail.local makewhatis.local mknetid pppoed revnetgroup  rpc.rquotad rpc.rstatd rpc.rusersd rpc.rwalld rpc.sprayd  rtld-elf save-entropy smrsh telnetd tests tftp-proxy ulog-helper ypxfr bootpd fingerd ftpd rbootd talkd tcpd tftpd hyperv "
SUBDIR is atf atrun blacklistd-helper comsat dma getty mail.local makewhatis.local mknetid pppoed revnetgroup  rpc.rquotad rpc.rstatd rpc.rusersd rpc.rwalld rpc.sprayd  rtld-elf save-entropy smrsh telnetd tests tftp-proxy ulog-helper ypxfr bootpd fingerd ftpd rbootd talkd tcpd tftpd hyperv 

make -f  makefile.jhs _rshd=rshd xx
echo "SUBDIR is atf atrun blacklistd-helper comsat dma getty mail.local makewhatis.local mknetid pppoed revnetgroup  rpc.rquotad rpc.rstatd rpc.rusersd rpc.rwalld rpc.sprayd rshd rtld-elf save-entropy smrsh telnetd tests tftp-proxy ulog-helper ypxfr bootpd fingerd ftpd rbootd talkd tcpd tftpd hyperv "
SUBDIR is atf atrun blacklistd-helper comsat dma getty mail.local makewhatis.local mknetid pppoed revnetgroup  rpc.rquotad rpc.rstatd rpc.rusersd rpc.rwalld rpc.sprayd rshd rtld-elf save-entropy smrsh telnetd tests tftp-proxy ulog-helper ypxfr bootpd fingerd ftpd rbootd talkd tcpd tftpd hyperv 

Cheers,
Julian
-- 
Julian H. Stacey, Computer Consultant, BSD Linux Unix Systems Engineer, Munich
 Reply below, Prefix '> '. Plain text, No .doc, base64, HTML, quoted-printable.
 http://berklix.eu/brexit/#3,500,000_stolen_votes_inc_700,000_in_EU