Re: SVN r327444 breaks current build

From: Oleksandr Tymoshenko <gonzo_at_freebsd.org>
Date: Sun, 31 Dec 2017 14:22:35 -0800
Michael Butler (imb_at_protected-networks.net) wrote:
> Building /usr/obj/usr/src/amd64.amd64/sys/VM01/vt_font_default.o
> --- vt_termcolors.o ---
> /usr/src/sys/dev/vt/colors/vt_termcolors.c:158:55: error: too many
> arguments to function call, expected 4, have 5
>                         if (vt_parse_rgb_triplet(rgb, strlen(rgb), &r,
> &g, &b) == 0) {
>                             ~~~~~~~~~~~~~~~~~~~~
>   ^~
> /usr/src/sys/dev/vt/colors/vt_termcolors.c:77:1: note:
> 'vt_parse_rgb_triplet' declared here
> static int
> ^
> 1 error generated.
> *** [vt_termcolors.o] Error code 1
> 
> <sigh> .. second time today a commit wasn't tested before commit :-(
> 
> 	imb

Should be fixed in r327449. It was a sloppy job, I was making iterative
improvements to the original patch following review feedback and used
out-of-tree testcases for actual testing. I appologize for the breakage.

-- 
gonzo
Received on Sun Dec 31 2017 - 21:22:43 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:14 UTC