Re: build with WITHOUT_GPL_DTC=y broken?

> On Feb 13, 2017, at 3:57 PM, Dimitry Andric <dim_at_FreeBSD.org> wrote:
> 
> On 13 Feb 2017, at 20:27, Matteo Riondato <matteo_at_freebsd.org> wrote:
>> 
>>> On Feb 13, 2017, at 1:58 PM, Dimitry Andric <dim_at_FreeBSD.org> wrote:
>>> On 13 Feb 2017, at 16:53, Matteo Riondato <matteo_at_freebsd.org> wrote:
>>>> 
>>>> When I build world with WITHOUT_GPL_DTC=y in src.conf (complete file after the error) I get the following error in stage 1.2: bootstrap tools. This is not a recent breakage, I’ve experienced it for a while.
>>>> 
>>>> ===> usr.bin/dtc (obj,all,install)
>>>> /usr/obj/usr/src/tmp/usr/src/usr.bin/dtc created for /usr/src/usr.bin/dtc
>>>> echo dtc: /usr/lib/libc.a /usr/obj/usr/src/tmp/legacy/usr/lib/libegacy.a >> .depend
>>>> echo dtc: /usr/lib/libc++.a >> .depend
>>>> c++  -O2 -pipe -DNDEBUG -MD -MF.depend.dtc.o -MTdtc.o -Qunused-arguments -I/usr/obj/usr/src/tmp/legacy/usr/include -std=c++11 -fno-rtti -fno-exceptions  -Wno-c++11-extensions -c /usr/src/usr.bin/dtc/dtc.cc -o dtc.o
>>>> c++  -O2 -pipe -DNDEBUG -MD -MF.depend.input_buffer.o -MTinput_buffer.o -Qunused-arguments -I/usr/obj/usr/src/tmp/legacy/usr/include -std=c++11 -fno-rtti -fno-exceptions  -Wno-c++11-extensions -c /usr/src/usr.bin/dtc/input_buffer.cc -o input_buffer.o
>>>> /usr/src/usr.bin/dtc/input_buffer.cc:547:53: error: type 'dtc::(anonymous namespace)::expression' is not a direct or virtual base of 'binary_operator<Precedence, Op>'
>>>>     binary_operator(source_location l, const char *) : expression(l) {}
>>>>                                                        ^~~~~~~~~~
>>> 
>>> Which FreeBSD version are you running on the host?  I've just tried
>>> building head/usr.bin/dtc on 12-CURRENT, 11-STABLE and 10-STABLE, but it
>>> all works just fine for me.
>> 
>> Very interesting. I’m using 12.0-CURRENT #2 r313159.
>> 
>> I even did two 'make cleandir' in /usr/src and removed /usr/obj/ , and still it does not compile.
> 
> I see now, this is because you are using WITHOUT_ASSERT_DEBUG.  This
> adds -DNDEBUG to CFLAGS, and apparently you are the first person to hit
> this NDEBUG-only code. :)
> 
> I committed a fix in r313709.

Thank you!

Matteo