Re: [bmake] bmake sigint handling causing tty corruption

From: Simon J. Gerraty <sjg_at_juniper.net>
Date: Wed, 19 Jul 2017 19:00:17 -0700
Hi Dmitry

Thanks for the detailed report.

Will take a look....

> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215572

> Now to fix this, I suggest that instead of killing itself, make should
> signal all its childs carefully and wait() on them, only then die
> itself.
> 
> Now after a quick glance at bmake sources it seems like the jobs control
> code
> 
> https://svnweb.freebsd.org/base/head/contrib/bmake/job.c?revision=317239&view=markup#l2633
> 
> does the very same thing that I've just described, however bmake is run
> in compat mode by default, and CompatInterrupt does exactly what ktrace
> shows - it just kills itself.
> 
> https://svnweb.freebsd.org/base/head/contrib/bmake/compat.c?revision=310304&view=markup#l180
> 
> So, to fix this problem it seems that CompatInterrupt should be improved
> as described above.
Received on Thu Jul 20 2017 - 00:00:36 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:12 UTC