Re: tools/tools/zfsboottest doesn't compile on ^/head

> On Jul 31, 2017, at 16:21, Ngie Cooper <yanegomi_at_gmail.com> wrote:
> 
> Hi,
> 	It looks like zfsboottest no longer compiles on ^/head (guessing it has to do with the clang upgrade).
> 	If someone doesn’t fix this build breakage in the next few hours, I’ll take a stab at fixing it.
> Thanks,
> -Ngie
> 
> PS zfsboottest should really be compiled with world if MK_ZFS != no.
> 
> $ (cd tools/tools/zfsboottest/; make obj; make)
> cc  -O1  -I/usr/src/tools/tools/zfsboottest/../../../sys/boot/zfs  -I/usr/src/tools/tools/zfsboottest/../../../sys/cddl/boot/zfs  -I.  -fdiagnostics-show-option  -W -Wextra -Wno-sign-compare -Wno-unused-parameter -m32   -g --coverage -MD  -MF.depend.zfsboottest.o -MTzfsboottest.o -std=gnu99 -fstack-protector-strong    -Qunused-arguments  -c /usr/src/tools/tools/zfsboottest/zfsboottest.c -o zfsboottest.o
> In file included from /usr/src/tools/tools/zfsboottest/zfsboottest.c:56:
> /usr/src/tools/tools/zfsboottest/../../../sys/boot/zfs/zfsimpl.c:797:9: error: returning 'void' from a function with incompatible result type 'int'
>        return (pager_output(line));
>               ^~~~~~~~~~~~~~~~~~~~
> /usr/src/tools/tools/zfsboottest/../../../sys/boot/zfs/zfsimpl.c:2356:17: warning: array index 264 is past the end of the array (which contains 192 elements) [-Warray-bounds]
>                memcpy(path, &dn->dn_bonus[sizeof(znode_phys_t)], psize);
>                              ^            ~~~~~~~~~~~~~~~~~~~~
> /usr/src/tools/tools/zfsboottest/../../../sys/cddl/boot/zfs/zfsimpl.h:910:2: note: array 'dn_bonus' declared here
>        uint8_t dn_bonus[DN_MAX_BONUSLEN - sizeof (blkptr_t)];
>        ^
> 1 warning and 1 error generated.
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/src/tools/tools/zfsboottest
> 
> 157873        imp void
> 157873        imp printf(const char *fmt,…)
> 104679        phk static void printf(const char *,...);

	The declaration for putchar is not ANSI compliant either — which is probably another fun hurdle that someone’s going to have to deal with in terms of fixing sys/boot and libstand.
Thanks,
-Ngie