Re: svn commit: r317659 - head/sys/dev/uart [head -r317729 for armv6/7: ns8250_drain : error: implicit declaration of function 'ns8250_drain' is invalid in C99]

On 2017-May-3, at 4:47 AM, Mark Millard <markmi_at_dsl-only.net> wrote:

>> Author: mav
>> Date: Mon May  1 19:47:10 2017
>> New Revision: 317659
>> URL: 
>> https://svnweb.freebsd.org/changeset/base/317659
>> 
>> 
>> Log:
>>  Make some UART consoles to not spin wait for data to be sent.
>> 
>>  At least with Tx FIFO enabled it shows me ~10% reduction of verbose boot
>>  time with serial console at 115200 baud.
>> 
>>  Reviewed by:	marcel
>>  MFC after:	2 weeks
>> 
>> Modified:
>>  head/sys/dev/uart/uart_dev_lpc.c
>>  head/sys/dev/uart/uart_dev_ns8250.c
> 
> 
> After building head -r317729 for amd64 and aarch64,
> when I tried armv6 I instead got the following failure:
> 
> --- uart_dev_lpc.o ---
> /usr/src/sys/dev/uart/uart_dev_lpc.c:892:4: error: implicit declaration of function 'ns8250_drain' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>                        ns8250_drain(bas, UART_DRAIN_TRANSMITTER);
>                        ^
> /usr/src/sys/dev/uart/uart_dev_lpc.c:892:4: note: did you mean 'lpc_ns8250_drain'?
> /usr/src/sys/dev/uart/uart_dev_lpc.c:140:1: note: 'lpc_ns8250_drain' declared here
> lpc_ns8250_drain(struct uart_bas *bas, int what)
> ^
> /usr/src/sys/dev/uart/uart_dev_lpc.c:892:4: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
>                        ns8250_drain(bas, UART_DRAIN_TRANSMITTER);
>                        ^
> 2 errors generated.

head -r317752 appears to have fixed this: a rebuild
based on -r317784 completed for armv6.

Thanks.

===
Mark Millard
markmi at dsl-only.net