Re: Head build unsafe for /etc today

From: Steve Kargl <sgk_at_troutmask.apl.washington.edu>
Date: Thu, 2 Nov 2017 20:50:10 -0700
On Thu, Nov 02, 2017 at 07:41:21PM -0700, Bryan Drewery wrote:
> 
> Are you accusing me of lying?
> 

Nope.  I'm stating the obvious.  If you are using
META_MODE and you do "make buildwould" that is 
equivalent to "make -DNO_CLEAN buildworld", which
means you did not rebuild the *world*. 

When I see a commit message of the form (and I've
haven't seen one like this in 25+ years of using
FreeBSD (aka 386BSD+patchkit))

Author: bdrewery
Date: Thu Nov  2 22:23:00 2017
New Revision: 325347
URL: https://svnweb.freebsd.org/changeset/base/325347

Log:
  Something is very wrong

Modified:
  head/Makefile

Modified: head/Makefile
==============================================================================
--- head/Makefile	Thu Nov  2 21:58:18 2017	(r325346)
+++ head/Makefile	Thu Nov  2 22:23:00 2017	(r325347)
_at__at_ -1,3 +1,4 _at__at_
+.error Bad revision, please wait for a fix in head

It suggests that whomever did the commit did not properly test
the patch.  The use of META_MODE (or any other shortcut) when
testing simply isn't proper testing.

-- 
Steve
Received on Fri Nov 03 2017 - 02:50:11 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:13 UTC