Re: head -r326193 (e.g.) buildworld broken: rejecting some . . ./usr/src/amd64.amd64/tmp/usr/include/stdio.h content

Thank you for the report ...


On 11/25/17 15:15, Mark Millard wrote:
> [Quick top post:]
>
> Reverting to -r326192 and rebuilding avoided the issue.
>   
> Prior notes:
>
> On 2017-Nov-25, at 12:02 PM, Mark Millard <markmi at dsl-only.net> wrote:
>
>> For example,
>>
>> /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/stdio.h:449:47: error: function definition is not allowed here
>> static __inline int __sputc(int _c, FILE *_p) {
>>
>> for:
>>
>> /*
>> * The __sfoo macros are here so that we can
>> * define function versions in the C library.
>> */
>> #define __sgetc(p) (--(p)->_r < 0 ? __srget(p) : (int)(*(p)->_p++))
>> #if defined(__GNUC__) && defined(__STDC__)
>> static __inline int __sputc(int _c, FILE *_p) {
>>         if (--_p->_w >= 0 || (_p->_w >= _p->_lbfsize && (char)_c != '\n'))
>>                 return (*_p->_p++ = _c);
>>         else
>>                 return (__swbuf(_c, _p));
>> }
>> #else
>> /*
>> * This has been tuned to generate reasonable code on the vax using pcc.
>> */
>> #define __sputc(c, p) \
>>         (--(p)->_w < 0 ? \
>>                 (p)->_w >= (p)->_lbfsize ? \
>>                         (*(p)->_p = (c)), *(p)->_p != '\n' ? \
>>                                 (int)*(p)->_p++ : \
>>                                 __swbuf('\n', p) : \
>>                         __swbuf((int)(c), p) : \
>>                 (*(p)->_p = (c), (int)*(p)->_p++))
>> #endif
>>
>>
>>
>> More of the prefix of the messages:
>>
>>
>>
>> --- var.o ---
>> In file included from /usr/src/bin/sh/var.c:70:
>> In file included from /usr/src/bin/sh/myhistedit.h:35:
>> In file included from /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/histedit.h:48:
>> /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/stdio.h:255:6: warning: declaration of built-in function 'fprintf' requires inclusion of the header <stdio.h> [-Wbuiltin-requires-header]
>> int      fprintf(FILE * __restrict, const char * __restrict, ...);
>>          ^
>> /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/stdio.h:260:6: warning: declaration of built-in function 'fscanf' requires inclusion of the header <stdio.h> [-Wbuiltin-requires-header]
>> int      fscanf(FILE * __restrict, const char * __restrict, ...);
>>          ^
>> --- csh_make ---
>> Building /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/rescue/rescue/usr/src/bin/csh/sh.init.o
>> --- sh_make ---
>> /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/stdio.h:284:6: warning: declaration of built-in function 'vfprintf' requires inclusion of the header <stdio.h> [-Wbuiltin-requires-header]
>> int      vfprintf(FILE * __restrict, const char * __restrict,
>>          ^
>> /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/stdio.h:293:6: warning: declaration of built-in function 'vfscanf' requires inclusion of the header <stdio.h> [-Wbuiltin-requires-header]
>> int      vfscanf(FILE * __restrict, const char * __restrict, __va_list)
>>          ^
>> /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/stdio.h:449:47: error: function definition is not allowed here
>> static __inline int __sputc(int _c, FILE *_p) {
>>                                               ^
>> In file included from /usr/src/bin/sh/var.c:70:
>> In file included from /usr/src/bin/sh/myhistedit.h:35:
>> In file included from /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/histedit.h:254:
>> In file included from /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/wchar.h:69:
>> In file included from /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/_ctype.h:97:
>> /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/runetype.h:96:1: error: function definition is not allowed here
>> {
>> ^
>> In file included from /usr/src/bin/sh/var.c:70:
>> In file included from /usr/src/bin/sh/myhistedit.h:35:
>> In file included from /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/histedit.h:254:
>> In file included from /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/wchar.h:69:
>> /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/include/_ctype.h:101:1: error: function definition is not allowed here
>> {
>> ^
>> . . . (much omitted) . . .

I can't reproduce it ...
I have been running tinderbox builds with the changes for a while.

Jenkins wasn't affected either:
https://ci.freebsd.org/job/FreeBSD-head-amd64-build/6040/

I have seen problems on arm with zstd though.

Pedro.