Re: /sys/boot compile broken

On Sun, Oct 22, 2017 at 10:53 AM, Gary Jennejohn <gljennjohn_at_gmail.com>
wrote:

> On Sun, 22 Oct 2017 08:59:52 -0600
> Warner Losh <imp_at_bsdimp.com> wrote:
>
> > On Sun, Oct 22, 2017 at 1:39 AM, Gary Jennejohn <gljennjohn_at_gmail.com>
> > wrote:
> >
> > > On Sat, 21 Oct 2017 09:33:41 -0600
> > > Warner Losh <imp_at_bsdimp.com> wrote:
> > >
> > > > On Oct 21, 2017 8:02 AM, "Allan Jude" <allanjude_at_freebsd.org> wrote:
> > > >
> > > > On 2017-10-21 02:41, Gary Jennejohn wrote:
> > > > > SVN for HEAD source at 324810.
> > > > >
> > > > > Compiling /sys/boot is totally screwed up.  The failure is that
> > > > > geliboot.c cannot be found.
> > > > >
> > > > > This prevents a successful ``make buildworld''.
> > > > >
> > > > > This error occurs despite the fact that I have
> LOADER_NO_GELI_SUPPORT
> > > > > set to yes in src.conf.
> > > > >
> > > > > Looking at the various Makefiles this option is supposed to prevent
> > > > > using GELI.
> > > > >
> > > > > Even if the user wanted to use GELI the compile of the boot code
> > > > > would probably fail.
> > > > >
> > > > > imp_at_ has had his fingers in the boot code lately.
> > > > >
> > > >
> > > > Some of the boot code has been changed over to LOADER_GELI_SUPPORT=no
> > > >
> > > > And so you ended up with some code not guarded. Add the additional
> > > > src.conf knob for now, and Warner will get it fixed up
> > > >
> > > >
> > > > I fly back from legoland today and will touch this up. I'm in the
> process
> > > > of changing them into real config knobs from the weird things that
> have
> > > > leaked out... sys/boot is likely moving my up to boot as well in the
> near
> > > > future.
> > > >
> > >
> > > Thanks for the info.
> > >
> > > I see that this change was made fairly late in my time zone.
> >
> >
> > mine too :) I was going to reply to this thread, but it was too late...
> >
> > Please let me know if it works for you. I was able to do builds both
> ways.
> >
>
> It worked.  It was good to see that you put an entry in UPDATING.
>

People noticing was a good clue I'd been remiss in the initial round of
commits.

Warner