Re: Call for Testing: UEFI Changes

From: Kyle Evans <kevans_at_freebsd.org>
Date: Mon, 2 Apr 2018 20:07:34 -0500
On Mon, Apr 2, 2018 at 5:51 PM, Zaphod Beeblebrox <zbeeble_at_gmail.com> wrote:
> On Sun, Apr 1, 2018 at 7:41 PM, David NewHamlet <wheelcomplex_at_gmail.com>
> wrote:
>>
>> Fixed in: FreeBSD-12.0-CURRENT-amd64-20180329-r331740-disc1.iso
>>
>>
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=176694
>>
>> On Mon, Apr 2, 2018 at 12:38 AM, Tomoaki AOKI <junchoon_at_dec.sakura.ne.jp>
>> wrote:
>>
>> > Confirmed both loader (with boot1) part and efirt.ko part.
>> > Working OK on my ThinkPad420 (with nvidia GPU) at r331864.
>> >
>> > No benefit (VGA resolution) but no new harm (no panic nor silent
>> > reboot).
>> >
>> >  *Maybe gracefully falling back to mode 0.
>> >
>> > As I'm on x11/nvidia-driver, completely no test is done with
>> > drm-next.
>> >
>> > One more to mention.
>> > I've cherry-picked r330868, r331241 and r331361 on stable/11 after
>> > r331114, amd64 and works OK as on head.
>> > Additional cherry-picking of r331365 is OK, too.
>> >
>> > Without r330868, my ThinkPad silently reboots within about 10-60
>> > minutes range, maybe by actual access to UEFI RS.
>> > With r331241 without r331361 causes instant panic on loading efirt.ko.
>> > So all 3 (4) revs should be MFC'ed together.
>> >
>> > Sorry for delay.
>> >
>> >
>> > On Thu, 22 Mar 2018 10:34:33 -0500
>> > Kyle Evans <kevans_at_freebsd.org> wrote:
>> >
>> > > On Thu, Mar 22, 2018 at 10:18 AM, Kyle Evans <kevans_at_freebsd.org>
>> > > wrote:
>> > > > On Thu, Mar 22, 2018 at 10:16 AM, Peter Lei <peter.lei_at_ieee.org>
>> > wrote:
>> > > >> On 3/22/18 8:56 AM, Tomoaki AOKI wrote:
>> > > >>> Hi.
>> > > >>> For problem 2, try reverting r331241 alone.
>> > > >>> This worked for my ThinkPad T420.
>> > > >>
>> > > >>
>> > > >> I also hit this after updating to latest and was about to post when
>> > > >> I
>> > > >> saw this thread -
>> > > >>
>> > > >> I build efirt into the kernel and it's now doing a panic on boot.
>> > > >> It
>> > > >> appears to be due to this recent addition in dev/efidev/efirt.c by
>> > r331241:
>> > > >>
>> > > >>>         if (!efi_is_in_map(map, efihdr->memory_size /
>> > efihdr->descriptor_size,
>> > > >>>             efihdr->descriptor_size,
>> > > >>> (vm_offset_t)efi_runtime->rt_gettime))
>> > {
>> > > >>
>> > > >> The faulting address is for "efi_runtime->rt_gettime" (and is still
>> > > >> a
>> > > >> phys addr here).
>> > > >>
>> > > >
>> > > > The following patch [1] (I can't guarantee how long he'll keep it
>> > > > available there) should fix this class of problems.
>> > > >
>> > > > [1] https://people.freebsd.org/~andrew/0001-Enter-into-the-
>> > EFI-environment-before-check-the-GetT.patch
>> > >
>> > > Now committed as of r331361.
>> > > _______________________________________________
>> > > freebsd-current_at_freebsd.org mailing list
>> > > https://lists.freebsd.org/mailman/listinfo/freebsd-current
>> > > To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_
>> > freebsd.org"
>> > >
>> >
>> >
>> > --
>> > Tomoaki AOKI    <junchoon_at_dec.sakura.ne.jp>
>> > _______________________________________________
>> > freebsd-current_at_freebsd.org mailing list
>> > https://lists.freebsd.org/mailman/listinfo/freebsd-current
>> > To unsubscribe, send any mail to
>> > "freebsd-current-unsubscribe_at_freebsd.org"
>> >
>> _______________________________________________
>> freebsd-current_at_freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/freebsd-current
>> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>
> I've booted that image on my zbook 15.  I show in the boot that I can
> deliberately load efirt.ko ... and it doesn't help.  I also show that I can
> "type blind" after the system boots ... so everything but the screen is
> working.
>
> In case you can't quite make it out, I hit right cursor twice (move to the
> "live cd" choice) and hit enter.  Then I type "root" enter and then "reboot"
> ...

That is interesting indeed... that's perhaps the polar opposite of
what was being experienced before- it looks like it's setting a higher
resolution but the firmware isn't actually putting it into the higher
resolution. The firmware then lies to us about what resolution it's
actually in, so we tell the kernel the wrong thing.

You should be able to confirm this, as I recall, by bumping into the
loader prompt and inspecting the output of `gop get`. That should
report a higher resolution than it's actually in.

> https://youtu.be/tlmaVJ-3aq0
>
> (The rock sound track is just free audio to mask a barking dog and a radio
> in the background.)
>

This was a most enjoyable soundtrack.
Received on Mon Apr 02 2018 - 23:13:39 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:15 UTC