Re: buildworld fails: fatal error: 'netpfil/pf/pf.h' file not found

On Mon, Apr 09, 2018, Kristof Provost wrote:
> On 9 Apr 2018, at 10:50, Vladimir Zakharov wrote:
> 
>     For several days buildworld fails for me with the following error. Cleaning
>     and
>     rebuilding didn't help.
> 
>     ===> tests/sys/netpfil/pf/ioctl (all)
>     --- validation ---
>     (cd /usr/src/tests/sys/netpfil/pf/ioctl && DEPENDFILE=.depend.validation
>     NO_SUBDIR=1 make -f /usr/src/tests/sys/netpfil/pf/ioctl/Makefile
>     _RECURSING_PROGS=t PROG=validation )
>     Building /home/obj/usr/src/amd64.amd64/tests/sys/netpfil/pf/ioctl/
>     validation.o
>     --- validation.o ---
>     In file included from /usr/src/tests/sys/netpfil/pf/ioctl/validation.c:35:
>     /home/obj/usr/src/amd64.amd64/tmp/usr/include/net/pfvar.h:49:10: fatal
>     error: 'netpfil/pf/pf.h' file not found
>     #include <netpfil/pf/pf.h>
>     ^~~~~~~~~~~~~~~~~
>     1 error generated.
>     *** [validation.o] Error code 1
> 
>     make[8]: stopped in /usr/src/tests/sys/netpfil/pf/ioctl
> 
> 
>     My /etc/src.conf (I have PF switched off):
> 
> Ah, that’s my fault. I didn’t consider people who’d switch off pf when I added
> the new ioctl tests.
> 
> You can work around the issue by removing the new tests yourself, or by
> building pf in anyway (it won’t do anything unless you load the module and
> activate it).
> 
> This should be a workaround for you until I can commit a better fix:
> 
> diff --git a/tests/sys/netpfil/pf/Makefile b/tests/sys/netpfil/pf/Makefile
> index c055e6840bd..259e1275d9c 100644
> --- a/tests/sys/netpfil/pf/Makefile
> +++ b/tests/sys/netpfil/pf/Makefile
> _at__at_ -3,7 +3,6 _at__at_
>  PACKAGE=       tests
> 
>  TESTSDIR=       ${TESTSBASE}/sys/netpfil/pf
> -TESTS_SUBDIRS+=        ioctl
> 
>  ATF_TESTS_SH+= pass_block \
>                 forward \

Thanks. I've applied this fix for now and managed to update.


-- 
Regards,                 | "In theory there is no difference between theory
  Vladimir Zakharov      | and practice. In practice there is."- Yogi Berra