Re: Native Encryption for ZFS on FreeBSD CFT

of course interesting work, but unfortunately, and as you know me,
what would i say next

cc -target x86_64-unknown-freebsd12.0
--sysroot=/usr/obj/usr/src/amd64.amd64/tmp
-B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin  -O2 -pipe
-I/usr/src/sys/cddl/compat/opensolaris
-I/usr/src/cddl/compat/opensolaris/include
-I/usr/src/cddl/compat/opensolaris/lib/libumem
-I/usr/src/cddl/contrib/opensolaris/lib/libzpool/common
-I/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
-I/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua
-I/usr/src/sys/cddl/contrib/opensolaris/common/zfs
-I/usr/src/sys/cddl/contrib/opensolaris/uts/common
-I/usr/src/cddl/contrib/opensolaris/head
-I/usr/src/cddl/contrib/opensolaris/lib/libnvpair
-I/usr/src/cddl/contrib/opensolaris/lib/libcmdutils
-DWANTS_MUTEX_OWNED -I/usr/src/lib/libpthread/thread
-I/usr/src/lib/libpthread/sys -I/usr/src/lib/libthr/arch/amd64/include
-g -DDEBUG=1 -DZFS_DEBUG=1   -DNEED_SOLARIS_BOOLEAN -g -MD
-MF.depend.freebsd_crypto.o -MTfreebsd_crypto.o -std=iso9899:1999
-fstack-protector-strong -Wno-pointer-sign -Wno-unknown-pragmas
-Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable
-Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
-Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef
-Wno-address-of-packed-member -Wno-switch -Wno-switch-enum
-Wno-knr-promoted-parameter -Wno-parentheses  -Qunused-arguments  -c
/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c
-o freebsd_crypto.o
/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:62:19:
warning: tentative definition of variable with internal linkage has
incomplete non-array type 'struct mtx'
[-Wtentative-definition-incomplete-type]
static struct mtx freebsd_crypto_mutex;
                  ^
/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:62:15:
note: forward declaration of 'struct mtx'
static struct mtx freebsd_crypto_mutex;
              ^
/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:63:35:
error: expected identifier
MTX_SYSINIT(freebsd_crypto_mutex, &freebsd_crypto_mutex, "FreeBSD ZFS
Crypto mutex", MTX_DEF);
                                  ^
/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:63:1:
warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
MTX_SYSINIT(freebsd_crypto_mutex, &freebsd_crypto_mutex, "FreeBSD ZFS
Crypto mutex", MTX_DEF);
^
/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:62:19:
error: tentative definition has type 'struct mtx' that is never
completed
static struct mtx freebsd_crypto_mutex;
                  ^
/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:62:15:
note: forward declaration of 'struct mtx'
static struct mtx freebsd_crypto_mutex;
              ^
2 warnings and 2 errors generated.
*** Error code 1
On Wed, Aug 22, 2018 at 4:28 AM Matthew Macy <mmacy_at_freebsd.org> wrote:
>
> On Tue, Aug 21, 2018 at 6:55 PM Matthew Macy <mmacy_at_freebsd.org> wrote:
>
> > To anyone with an interest in native encryption in ZFS please test the
> > projects/zfs-crypto-merge-0820 branch in my freebsd repo:
> > https://github.com/mattmacy/networking.git
> >
> >
> Oh and I neglected to state that this work is being supported by iX Systems
> and the tree is all built on work done by Sean Fagan at iX Systems. Please
> keep him in the loop on any problems encountered.
> Thanks.
>
>
>
> > ( git clone  https://github.com/mattmacy/networking.git -b
> > projects/zfs-crypto-merge-0820 )
> >
> > The UI is quite close to the Oracle Solaris ZFS crypto with minor
> > differences for specifying key location.
> >
> > Please note that once a feature is enabled on a pool it can't be
> > disabled. This means that if you enable encryption support on a pool
> > you will never be able to import it in to a ZFS without encryption
> > support. For this reason I would strongly advise against using this on
> > any pool that can't be easily replaced until this change has made its
> > way in to HEAD after the freeze has been lifted.
> >
> >
> > By way of background the original ZoL commit can be found at:
> >
> > https://github.com/zfsonlinux/zfs/pull/5769/commits/5aef9bedc801830264428c64cd2242d1b786fd49
> >
> > Thanks in advance.
> > -M
> >
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"