Re: HEAD buildworld fails in libc

On Fri, Dec 28, 2018 at 10:18:12AM +0100, Gary Jennejohn wrote:
> I don't know why this hasn't already been reported, but I've been
> seeing this error since the commit was made.
> 
> ===> lib/libc (obj,all,install)
> /usr/src/lib/libc/string/strerror.c:96:11: error: passing 'const char []' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>                         __uprefix,
>                         ^~~~~~~~~
> /usr/src/lib/libc/string/strerror.c:61:23: note: passing argument to parameter 'uprefix' here
> errstr(int num, char *uprefix, char *buf, size_t len)
>                       ^
> 1 error generated.
> *** [strerror.o] Error code 1
> 
> I deleted /usr/obj, disabled META_MODE and ran the ``make buildworld''
> with -j1.
> 
> My /usr/src is at r342569.

Do you have WITHOUT_NLS set ?  If yes, then the following should fix it.
Confirm and I will commit.

diff --git a/lib/libc/string/strerror.c b/lib/libc/string/strerror.c
index be3732d5b9e..7cd984ea48f 100644
--- a/lib/libc/string/strerror.c
+++ b/lib/libc/string/strerror.c
_at__at_ -58,7 +58,7 _at__at_ __FBSDID("$FreeBSD$");
  * statically linked binaries.
  */
 static void
-errstr(int num, char *uprefix, char *buf, size_t len)
+errstr(int num, const char *uprefix, char *buf, size_t len)
 {
 	char *t;
 	unsigned int uerr;