Re: svn commit: r335836 - head/usr.bin/top [broke ci.freebsd.org 's FreeBSD-head-riscv64-build]

https://ci.freebsd.org/job/FreeBSD-head-riscv64-build/9229/consoleText

--- utils.o ---
/usr/local/bin/riscv64-unknown-freebsd11.1-gcc --sysroot=/workspace/obj/workspace/src/riscv.riscv64/tmp -B/usr/local/riscv64-unknown-freebsd11.1/bin/  -O2 -pipe -march=rv64imafdc -mabi=lp64d   -g -MD  -MF.depend.utils.o -MTutils.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-error=address -Wno-error=array-bounds -Wno-error=attributes -Wno-error=bool-compare -Wno-error=cast-align -Wno-error=clobbered -Wno-error=enum-compare -Wno-error=extra -Wno-error=inline -Wno-error=logical-not-parentheses -Wno-error=strict-aliasing -Wno-error=uninitialized -Wno-error=unused-but-set-variable -Wno-error=unused-function -Wno-error=unused-value -Wno-error=misleading-indentation -Wno-error=nonnull-compare -Wno-error=shift-negative-value -Wno-error=tautological-compare -Wno-error=unused-const-variable -Wno-error=bool-operation -Wno-error=deprecated -Wno-error=expansion-to-defined -Wno-error=format-overflow -Wno-error=format-truncation -Wno-error=implicit-fallthrough -Wno-error=int-in-bool-context -Wno-error=memset-elt-size -Wno-error=nonnull -Wno-error=pointer-compare -Wno-error=stringop-overflow   -Wno-error=discarded-qualifiers -Wno-error=incompatible-pointer-types  -c /workspace/src/usr.bin/top/utils.c -o utils.o
/workspace/src/usr.bin/top/utils.c: In function 'utf8strvisx':
/workspace/src/usr.bin/top/utils.c:357:10: error: comparison is always true due to limited range of data type [-Werror=type-limits]
    if (0 <= *src_p && *src_p <= 31) {
          ^~

I'd guess that riscv64 has an unsigned type for *src_p --and that
fairly modern gcc complains where system clang and old gcc 4.2.1
do not complain for the issue.



===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)