Re: atomic changes break drm-next-kmod?

In message <20180703170223.266dbf5b_at_thor.intern.walstatt.dynvpn.de>, 
"O. Hartma
nn" writes:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Am Tue, 3 Jul 2018 10:19:57 -0400
> Michael Butler <imb_at_protected-networks.net> schrieb:
>
> > It seems recent changes (SVN r335873?) may have broken drm-next-kmod ..
> > 
> > --- i915_drv.o ---
> > In file included from i915_drv.c:30:
> > In file included from
> > /usr/ports/graphics/drm-next-kmod/work/kms-drm-a753215/linuxkpi/gplv2/inclu
> de/linux/acpi.h:26:
> > In file included from
> > /usr/ports/graphics/drm-next-kmod/work/kms-drm-a753215/linuxkpi/gplv2/inclu
> de/linux/device.h:4:
> > In file included from
> > /usr/src/sys/compat/linuxkpi/common/include/linux/device.h:35:
> > In file included from
> > /usr/src/sys/compat/linuxkpi/common/include/linux/types.h:37:
> > In file included from /usr/src/sys/sys/systm.h:44:
> > ./machine/atomic.h:450:29: error: invalid operand for instruction
> > ATOMIC_ASM(clear,    long,  "andq %1,%0",  "ir", ~v);
> >                             ^
> > <inline asm>:1:7: note: instantiated into assembly here
> >         andq $9223372036854775807,40672(%r14)
> >              ^~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> > *** [i915_drv.o] Error code 1
> > 
> > make[3]: stopped in
> > /usr/ports/graphics/drm-next-kmod/work/kms-drm-a753215/i915
> > --- i915_gem.o ---
> > In file included from i915_gem.c:28:
> > In file included from
> > /usr/ports/graphics/drm-next-kmod/work/kms-drm-a753215/include/drm/drmP.h:3
> 8:
> > In file included from /usr/src/sys/sys/malloc.h:42:
> > In file included from /usr/src/sys/sys/systm.h:44:
> > ./machine/atomic.h:449:29: error: invalid operand for instruction
> > ATOMIC_ASM(set,      long,  "orq %1,%0",   "ir",  v);
> >                             ^
> > <inline asm>:1:6: note: instantiated into assembly here
> >         orq $-9223372036854775808,40672(%r14)
> >             ^~~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> > *** [i915_gem.o] Error code 1
> > 
> > _______________________________________________
> > freebsd-current_at_freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/freebsd-current
> > To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>
>
> It breaks also graphics/drm-stable-kmod (see PR 229484,
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229484, same error as you d
> escribed
> above) and also emulators/virtualbox-ose-kmod. As long as CURRENT revision is
>  < r335873,
> those kmod compile well.

The virtualbox-ose-kmod issue is different. It's namespace pollution 
caused by the inclusion of sys/param.h in sys/systm.h when _KERNEL is 
defined. sys/param.h includes sys/priority.h if LOCORE is not defined. 
virtualbox typedefs PVM as a struct whereas sys/priority.h defines it 
as a constant. Virtualbox undefines PVM in some headers, usually after 
including sys/param.h. I haven't looked at it further than this with 
the limited time I have tonight but I suspect one of the #undef PVM 
statements needs to move.

> - -- 
> O. Hartmann
>
> Ich widerspreche der Nutzung oder Übermittlung meiner Daten für
> Werbezwecke oder für die Markt- oder Meinungsforschung (§ 28 Abs. 4 BDSG).
> -----BEGIN PGP SIGNATURE-----
>
> iLUEARMKAB0WIQQZVZMzAtwC2T/86TrS528fyFhYlAUCWzuQGgAKCRDS528fyFhY
> lKHnAf0fIVHnw1xBVHzogeQQo4v+he17R2ln6l25lNR/pUE1AZOsFzPDamAkqbY+
> f1+Usr+P5o7jn26Bh4ob3UmIj25DAf4tJZpeZS4iGZ374lrCAemYFb53+MJ1fClW
> aBLI6DVOiBiOt/UpLXZf1whl/dtQvo5yd1xywfYOwi9Jh8teHcNW
> =mtMH
> -----END PGP SIGNATURE-----
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>


-- 
Cheers,
Cy Schubert <Cy.Schubert_at_cschubert.com>
FreeBSD UNIX:  <cy_at_FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.