Re: Proper way to remove never used ioctls

From: Warner Losh <>
Date: Sat, 2 Jun 2018 09:03:04 -0600
On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev <>

> Hi,
> Our sys/mouse.h header has a definition of MOUSE_GETVARS and MOUSE_SETVARS
> ioctls which are not documented and only stubbed in a few drivers: mse(4),
> psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS
> implemented in psm(4)
> Given the fact that they were introduced 20 years ago, implementation was
> never completed and googling on them shows no traces of usage in indexed
> universe, is it acceptable to just drop both defines and implementation
> w.o. leaving any COMPAT_FREEBSD shims?

I'd prepare a patch just removing them. I'd then send that patch to the
ports mgr team and request a exp-run. Details for that can be found in

Once that's done, submit a Phabricator review and send me email. I'll make
sure it gets pushed in if there's no objections.

Received on Sat Jun 02 2018 - 13:03:06 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:16 UTC