Re: Error build nvidia-driver with r334555

​
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On June 3, 2018 8:21 AM, Konstantin Belousov <kostikbel_at_gmail.com> wrote:

> On Sun, Jun 03, 2018 at 05:08:34AM -0700, David Wolfskill wrote:
> 
> > On Sun, Jun 03, 2018 at 06:48:01PM +0700, Alex V. Petrov wrote:
> > 
> > > ....
> > > 
> > > --- nvidia_subr.o ---
> > > 
> > > nvidia_subr.c:367:26: error: 'memset' call operates on objects of type
> > > 
> > > 'struct nv_ioctl_card_info' while the size is based on a different type
> > > 
> > > 'struct nv_ioctl_card_info *' [-Werror,-Wsizeof
> > > 
> > > -pointer-memaccess]
> > > 
> > > memset(ci, 0, sizeof(ci));
> > > 
> > > ~~ ^~
> > > 
> > > nvidia_subr.c:367:26: note: did you mean to dereference the argument to
> > > 
> > > 'sizeof' (and multiply it by the number of elements)?
> > > 
> > >     memset(ci, 0, sizeof(ci));
> > >                          ^~
> > >     
> > > 
> > > 1 error generated.
> > > 
> > > *** [nvidia_subr.o] Error code 1
> > > 
> > > ....
> > 
> > Aye; please ref.
> > 
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228709 for
> > 
> > additional details.
> > 
> > The issue has been narrowed down to the range r334529 - r334535; I'm
> > 
> > suspecting r334533 and/or r334534. (Not that the commits are in any way
> > 
> > "faulty" -- merely that the nvidia-driver port may need some "evasive
> > 
> > action" to allow for the change).
> 
> Even not looking at the actual code, I am quite sure that the line
> 
> nvidia_subr.c:367 should be changed to
> 
> memset(ci, 0, sizeof(*ci));
> 
> This is a bug in the driver sources.
> 
> freebsd-current_at_freebsd.org mailing list
> 
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> 
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"



That solved the build problem for me. 
I haven't noticed any other issues with nvidia driver.


Waitman Gobble

Sent with ProtonMail Secure Email.​