Re: svn commit: r335753 - head/sbin/devd [ broke the ci.freebsd.org FreeBSD-head-{mips,mip64,powerpcpowerpc64,powerpcspe,sparc64}-build ]

[I used the wrong Email address the first time.]

On 2018-Jun-27, at 6:31 PM, Warner Losh <imp at bsdimp.com> wrote:
> 
> 
> 
> On Wed, Jun 27, 2018, 7:27 PM Mark Millard <marklmi26-fbsd_at_yahoo.com> wrote:
> These are the gcc/g++ 4.2.1 based targets.
> 
> For example . . .
> 
> https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/6261/consoleText
> 
> --- all_subdir_sbin/devd ---
> /usr/src/sbin/devd/devd.cc: In member function 'std::string config::shell_quote(const std::string&)':
> /usr/src/sbin/devd/devd.cc:652: error: a function-definition is not allowed here before ':' token
> /usr/src/sbin/devd/devd.cc:1327: error: expected primary-expression at end of input
> /usr/src/sbin/devd/devd.cc:1327: error: expected `;' at end of input
> /usr/src/sbin/devd/devd.cc:1327: error: expected primary-expression at end of input
> /usr/src/sbin/devd/devd.cc:1327: error: expected `)' at end of input
> /usr/src/sbin/devd/devd.cc:1327: error: expected statement at end of input
> /usr/src/sbin/devd/devd.cc:1327: error: expected `}' at end of input
> --- all_subdir_kerberos5 ---
> 
> 
> The following is modern C++ syntax that is being rejected:
> 
> . . .
>         for (const char &c : s) {
> . . .
> 
> (At least if I understand right.)
> 
> C++11 I thought was required. If not. That the issue. 

Looking at "C++11 Support in GCC" in:

https://gcc.gnu.org/projects/cxx-status.html

shows almost nothing is supported prior to
gcc 4.3 . Some things require gcc 4.8.1 .

As for "Range-based for": it requires gcc 4.6 .
The SD-6 feature test listed is:

__cpp_range_based_for >= 200907


===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)