Re: serial console vs suspend

From: Warner Losh <imp_at_bsdimp.com> Date: Thu, 17 May 2018 08:59:27 -0600 · This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:16 UTC

On Thu, May 17, 2018 at 7:28 AM, Andriy Gapon <avg_at_freebsd.org> wrote:

> On 17/05/2018 16:25, Ian Lepore wrote:
> > Why should it go through the console layer? If the uart hardware needs
> > some re-init on resume, won't that be true whether the uart is serving
> > as a console, a dial-in terminal, or the interface to wifi or bluetooth
> > chip?
>
> I think that for those things a normal device resume should do.
> console gets used very early, so it may require a special resume.
>

We should re-init both places (maybe with a flag to prevent double if
that's harmful). The console is needed very early after the resume, often
earlier than the accidental location in the device tree the console
device_t node lives. That way we don't lose output. The console layer gives
us a convenient hook early in resume to cope.  It's yet another reason,
though, it should be restricted to true console devices, but that's another
conversation.

Warner