Re: [RFC] Deprecation and removal of the drm2 driver

On 18/05/2018 20:58, Niclas Zeising wrote:
> [ Cross posted to freebsd-current_at_ and freebsd-x11_at_.  Please respect reply-to
> and send all replies to freebsd-x11_at_.  Thanks! ]
> 
> 
> Hi!
> I propose that we remove the old drm2 driver (sys/dev/drm2) from FreeBSD.  I
> suggest the driver is marked as deprecated in 11.x and removed from 12.0, as was
> done for other drivers recently.  Some background and rationale:
> 
> The drm2 driver was the original port of a KMS driver to FreeBSD.  It was done
> by Konstantin Belousov to support Intel graphics cards, and later extended by
> Jean-Sébastien Pédron as well as Konstantin to match what's in Linux 3.8.  This
> included unstable support from Haswell, but nothing newer than that.
> 
> For quite some time now we have had the graphics/drm-stable-kmod and
> graphics/drm-next-kmods which provides support for modern AMD and Intel graphics
> cards.  These ports, together with the linuxkpi, or lkpi, has made it
> significantly easier to port and update our graphics drivers. Further, these new
> drivers cover the same drivers as the old drm2 driver.
> 
> What does the community think?  Is there anyone still using the drm2 driver on
> 12-CURRENT?

Please count me as one.

>  If so, what is preventing you from switching to the port?

Suspend / resume does not work with my hardware:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
panic: implment me!!
cpuid = 0
time = 1526764859
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe004d1c2280
vpanic() at vpanic+0x1a3/frame 0xfffffe004d1c22e0
panic() at panic+0x43/frame 0xfffffe004d1c2340
linux_pci_save_state() at linux_pci_save_state+0x12/frame 0xfffffe004d1c2350
radeon_suspend_kms() at radeon_suspend_kms+0x524/frame 0xfffffe004d1c23a0
linux_pci_suspend() at linux_pci_suspend+0x6e/frame 0xfffffe004d1c23d0
...
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The hardware is old, supported by radeonkms as opposed to amdgpu, but still..
Also, last time I checked audio over HDMI did not work, but I haven't tested the
latest version yet.

Finally, a counter-question, does keeping the code in its current state
(unsupported, but without explicitly stating so) obstruct the work on the new code?

-- 
Andriy Gapon