Re: [RFC] Deprecation and removal of the drm2 driver

On Sun, May 20, 2018 at 06:47:07PM +0200, Niclas Zeising wrote:
> On 05/20/18 18:40, Steve Kargl wrote:
> > On Fri, May 18, 2018 at 02:03:32PM -0600, Warner Losh wrote:
> >> On Fri, May 18, 2018 at 1:30 PM, Steve Kargl <
> >>>
> >>> % more /usr/ports/graphics/drm-next-kmod/Makefile
> >>>
> >>> ONLY_FOR_ARCHS= amd64
> >>> ONLY_FOR_ARCHS_REASON=  the new KMS components are only supported on amd64
> >>>
> >>> Not to ia32 friendly.
> >>>
> >>
> >> So do people use i386 for desktop? And need the latest KMS stuff?
> >>
> > 
> > Just a data point.  I had to replace the dead disk in my laptop,
> > and after 2 days of doing a re-install and update of -current
> > on a shiny new SSD.
> > 
> > Before loading Xorg.
> > 
> > % kldstat
> > Id Refs Address    Size     Name
> >   1    7 0x800000 1ac31d4  kernel
> >   2    1 0x1e9ae000 5000     ums.ko
> >   3    1 0x1e9b9000 4000     uhid.ko
> > 
> > After starting Xorg without an xorg.conf in /etc/X11.
> > 
> > Id Refs Address    Size     Name
> >   1   27 0x800000 1ac31d4  kernel
> >   2    1 0x1e9ae000 5000     ums.ko
> >   3    1 0x1e9b9000 4000     uhid.ko
> >   4    1 0x1eaa9000 96000    i915kms.ko
> >   5    1 0x1eb40000 4a000    drm2.ko
> >   6    4 0x1eb8b000 5000     iicbus.ko
> >   7    1 0x1ebc9000 3000     iic.ko
> >   8    1 0x1ebcf000 4000     iicbb.ko
> > 
> > So, drm2.ko and i915kms.ko are loaded automatically.  It is
> > unclear why functionality that works should be removed.
> 
> One of the reasons for the deprecation and removal of the drm2 bits is 
> that they prevent us from automatically loading the drm-next/stable-kmod 
> kernel modules, since the two collide.
> Regards

They do not collide on non-AMD64 architectures.  Is is possible to do

svn diff sys/modules/Makefile
Index: sys/modules/Makefile
===================================================================
--- sys/modules/Makefile        (revision 333815)
+++ sys/modules/Makefile        (working copy)
_at__at_ -113,7 +113,9 _at__at_
        ${_dpms} \
        ${_dpt} \
        ${_drm} \
+.if ${MACHINE_ARCH} != AMD64
        ${_drm2} \
+.endif
        dummynet \
        ${_ed} \
        ${_efirt} \

-- 
Steve