Re: head -r333974 fix-to-the-build exposes another breaks-the-build problem in top (at least for gcc based builds)

On 2018-May-21, at 5:46 PM, Mark Millard <marklmi26-fbsd at yahoo.com> wrote:

> FreeBSD-head-amd64-gcc (based on a more modern gcc) reports a
> more explicit error for -r333974 and later:
> 
> --- all_subdir_usr.bin ---
> /workspace/src/usr.bin/top/commands.c:132:1: error: function declaration isn't a prototype [-Werror=strict-prototypes]
> scanint(str, intp)
> ^~~~~~~
> 
> The older gcc 4.2.1 builds report:
> 
> --- all_subdir_usr.bin/top ---
> cc1: warnings being treated as errors
> /usr/src/usr.bin/top/commands.c:134: warning: function declaration isn't a prototype
> *** [commands.o] Error code 1
> 
> make[4]: stopped in /usr/src/usr.bin/top
> 1 error

I should have been explicit that the material is from
ci.freebsd.org .

For reference, the gcc based builds seem to be:
(all but the last being gcc 4.2.1 based if I
undertand right)

FreeBSD-head-mips-build
FreeBSD-head-mips64-build
FreeBSD-head-powerpc-build
FreeBSD-head-powerpc64-build
FreeBSD-head-powerpcspe-build
FreeBSD-head-sparc64-build
FreeBSD-head-amd64-gcc

So those are what I'm reporting as having broken builds
for the specific issue.


===
Mark Millard
marklmi26-fbsd at yahoo.com
( dsl-only.net went
away in early 2018-Mar)