Re: ACPI Error: No handler for Region [ECOR]

On 18-11-20 11:28:56, Ben Widawsky wrote:
> On 18-11-20 14:09:08, Jung-uk Kim wrote:
> > On 18. 11. 20., Charlie Li wrote:
> > > Somewhere between r340491 and r340650, probably starting from r340595,
> > > my ThinkPad W550s started spewing these messages repeatedly in the
> > > system log since boot:
> > > 
> > > Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR]
> > > (0xfffff80003662300) [EmbeddedControl] (20181031/evregion-288)
> > > Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl
> > > (ID=3) has no handler (20181031/exfldio-428)
> > > Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution
> > > failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677)
> > > 
> > > As a result, I am now unable to query battery information at the very
> > > least. r340490 is my last built revision with this working.
> > 
> > I am pretty sure r340644 caused the regression.
> > 
> > https://svnweb.freebsd.org/changeset/base/340644
> > 
> > Jung-uk Kim
> 
> Seems like a good bet. Could you please add the full dmesg as well as an ACPI
> dump and the output of `sysctl dev.acpi_ec.` Thanks.

Just for a quick eyeball, this looks suspicious. You could also try this:
diff --git a/sys/dev/acpica/acpi_ec.c b/sys/dev/acpica/acpi_ec.c
index a21dbc963af..5d6dba6a887 100644
--- a/sys/dev/acpica/acpi_ec.c
+++ b/sys/dev/acpica/acpi_ec.c
_at__at_ -422,6 +422,7 _at__at_ acpi_ec_probe(device_t dev)
     /* Store the values we got from the namespace for attach. */
     acpi_set_private(dev, params);

+#if 0
     /*
      * Check for a duplicate probe. This can happen when a probe via ECDT
      * succeeded already. If this is a duplicate, disable this device.
_at__at_ -431,6 +432,7 _at__at_ acpi_ec_probe(device_t dev)
        ret = 0;
     else
        device_disable(dev);
+#endif

     if (buf.Pointer)
        AcpiOsFree(buf.Pointer);

-- 
Ben Widawsky, Intel Open Source Technology Center