Re: SVN r346316 breaks build

On 2019-04-17 20:45, Ed Maste wrote:
> On Wed, 17 Apr 2019 at 17:31, Michael Butler <imb_at_protected-networks.net> wrote:
>>
>> There seems to be a missing include here?
>>
>> ===> usr.bin/strings (obj,all,install)
>> Building
>> /usr/obj/usr/src/amd64.amd64/tmp/obj-tools/usr.bin/strings/strings.o
>> /usr/src/contrib/elftoolchain/strings/strings.c:198:55: error: use of
>> undeclared identifier 'FA_OPEN'
>>         fa = fileargs_init(argc, argv, O_RDONLY, 0, &rights, FA_OPEN);
> 
> I can't reproduce this and the CI builds
> (https://ci.freebsd.org/tinderbox) are all passing, although this was
> reported privately to me by others so something's up. What is the
> FreeBSD version on your build host?
> 

This is a native build on current. It fails with or without removing
/usr/obj/*.

Sean Eric Fagan (sef) pointed me to the fact that cap_fileargs.h is not
updated as part of the bootstrap-tools target. As I don't understand how
that target is built or configured, I successfully worked around it by
doing (on my amd64 host) ..

cp -p /usr/src/lib/libcasper/services/cap_fileargs/cap_fileargs.h \
	/usr/obj/usr/src/amd64.amd64/obj-lib32/tmp/usr/include/casper/
cp -p /usr/src/lib/libcasper/services/cap_fileargs/cap_fileargs.h \
	/usr/obj/usr/src/amd64.amd64/tmp/usr/include/casper/
cp -p /usr/src/lib/libcasper/services/cap_fileargs/cap_fileargs.h \
	/usr/include/casper/

	imb